[coreboot-gerrit] New patch to review for coreboot: ec/google/chromeec: don't guard function declarations

Aaron Durbin (adurbin@chromium.org) gerrit at coreboot.org
Thu May 12 23:10:14 CEST 2016


Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14796

-gerrit

commit 8fa9b6ad0ef541b8009ac320d8c05761791c7c91
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Thu May 12 16:08:28 2016 -0500

    ec/google/chromeec: don't guard function declarations
    
    In order to allow using the same C source to be compiled
    for multiple stages (with #if/#endif guards) one needs the
    necessary function delcarations. Therefore, remove the
    guards.
    
    Change-Id: Iea94d456451c5d3db8b8b339e81163b3b3fed3ed
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 src/ec/google/chromeec/ec.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/ec/google/chromeec/ec.h b/src/ec/google/chromeec/ec.h
index 19507bb..d3e6d78 100644
--- a/src/ec/google/chromeec/ec.h
+++ b/src/ec/google/chromeec/ec.h
@@ -24,7 +24,6 @@
 /* Fill in base and size of the IO port resources used. */
 void google_chromeec_ioport_range(uint16_t *base, size_t *size);
 
-#ifndef __PRE_RAM__
 int google_chromeec_i2c_xfer(uint8_t chip, uint8_t addr, int alen,
 			     uint8_t *buffer, int len, int is_read);
 u32 google_chromeec_get_wake_mask(void);
@@ -34,16 +33,13 @@ int google_chromeec_set_wake_mask(u32 mask);
 u8 google_chromeec_get_event(void);
 int google_ec_running_ro(void);
 void google_chromeec_init(void);
-#endif
 
-#ifdef __PRE_RAM__
 /* If recovery mode is enabled and EC is not running RO firmware reboot. */
 void google_chromeec_early_init(void);
 void google_chromeec_early_pd_init(void);
 /* Reboot if EC firmware is not expected type. */
 void google_chromeec_check_ec_image(int expected_type);
 void google_chromeec_check_pd_image(int expected_type);
-#endif
 
 int google_chromeec_check_feature(int feature);
 uint8_t google_chromeec_calc_checksum(const uint8_t *data, int size);



More information about the coreboot-gerrit mailing list