[coreboot-gerrit] New patch to review for coreboot: acpigen: Add functions to generate _STA() and _PRW()

Duncan Laurie (dlaurie@google.com) gerrit at coreboot.org
Thu May 12 22:40:56 CEST 2016


Duncan Laurie (dlaurie at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14795

-gerrit

commit 9d5d59695b24ddf5311b90f52b71d09f5925a908
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Mon May 9 11:08:46 2016 -0700

    acpigen: Add functions to generate _STA() and _PRW()
    
    Add helper functions for generating some common objects:
    
    acpigen_write_STA_always_on() will generate a status method that will
    indicate the device is always present:
      Method (_STA) { Return (0xF) }
    
    acpigen_write_STA_always_off() will generate a status method that will
    indicate the device is not present or powered or operational:
      Method (_STA) { Return (0x0) }
    
    acpigen_write_PRW() will generate a Power Resoruce for Wake that describes
    the GPE that will wake a particular device:
      Name (_PRW, Package (2) { wake, level }
    
    Change-Id: I10277f0f3820d272d3975abf34b9a8de577782e5
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
---
 src/arch/x86/acpigen.c              | 28 ++++++++++++++++++++++++++++
 src/arch/x86/include/arch/acpigen.h |  3 +++
 2 files changed, 31 insertions(+)

diff --git a/src/arch/x86/acpigen.c b/src/arch/x86/acpigen.c
index ea09b5b..9d69ada 100644
--- a/src/arch/x86/acpigen.c
+++ b/src/arch/x86/acpigen.c
@@ -456,6 +456,22 @@ void acpigen_write_device(const char *name)
 	acpigen_emit_namestring(name);
 }
 
+void acpigen_write_STA_always_on(void)
+{
+	acpigen_write_method("_STA", 0);
+	acpigen_emit_byte(0xa4);
+	acpigen_write_byte(0x0f);
+	acpigen_pop_len();
+}
+
+void acpigen_write_STA_always_off(void)
+{
+	acpigen_write_method("_STA", 0);
+	acpigen_emit_byte(0xa4);
+	acpigen_write_byte(0x00);
+	acpigen_pop_len();
+}
+
 /*
  * Generates a func with max supported P-states.
  */
@@ -510,6 +526,18 @@ void acpigen_write_TPC(const char *gnvs_tpc_limit)
 	acpigen_pop_len();
 }
 
+void acpigen_write_PRW(u32 wake, u32 level)
+{
+	/*
+	 * Name (_PRW, Package () { wake, level }
+	 */
+	acpigen_write_name("_PRW");
+	acpigen_write_package(2);
+	acpigen_write_integer(wake);
+	acpigen_write_integer(level);
+	acpigen_pop_len();
+}
+
 void acpigen_write_PSS_package(u32 coreFreq, u32 power, u32 transLat,
 			      u32 busmLat, u32 control, u32 status)
 {
diff --git a/src/arch/x86/include/arch/acpigen.h b/src/arch/x86/include/arch/acpigen.h
index 2555164..3c45cd5 100644
--- a/src/arch/x86/include/arch/acpigen.h
+++ b/src/arch/x86/include/arch/acpigen.h
@@ -58,6 +58,9 @@ void acpigen_write_PPC(u8 nr);
 void acpigen_write_PPC_NVS(void);
 void acpigen_write_empty_PCT(void);
 void acpigen_write_empty_PTC(void);
+void acpigen_write_PRW(u32 wake, u32 level);
+void acpigen_write_STA_always_on(void);
+void acpigen_write_STA_always_off(void);
 void acpigen_write_TPC(const char *gnvs_tpc_limit);
 void acpigen_write_PSS_package(u32 coreFreq, u32 power, u32 transLat, u32 busmLat,
 			u32 control, u32 status);



More information about the coreboot-gerrit mailing list