[coreboot-gerrit] Patch merged into coreboot/master: google/gru: Determine Board ID based on the input voltage of ADC1

gerrit at coreboot.org gerrit at coreboot.org
Mon May 9 08:47:36 CEST 2016


the following patch was just integrated into master:
commit 93649b122e354341e2556173f2a427c94cb6a8d6
Author: Vadim Bendebury <vbendeb at chromium.org>
Date:   Fri Apr 22 07:03:43 2016 -0700

    google/gru: Determine Board ID based on the input voltage of ADC1
    
    The Board ID on the Gru family of boards is determined by reading the
    voltage from a resistor divider, each hardware revision is supposed to
    have a unique resistor ratio, which allows to distinctly tell between
    different Board ID.
    
    While the long time approach to mapping resistor ratios (and voltages)
    into Board ID remains under discussion, we know for sure the values
    for Proto 1 and Proto 2. Let's just use them for now.
    
    Since Board ID can be queried multiple times during boot, ideally it
    should be read once and placed in the coreboot table to be available
    to all coreboot stages. For now we just cache it so that at least
    during the same stage the ADC has to run only once.
    
    BRANCH=None
    BUG=chrome-os-partner:51537
    TEST=verified that the voltage reading on Proto 1 is as expected, and
         Board ID 0 is reported.
    
    Change-Id: I94bc7fc235dae4155feb6ca35b5ef0ab20c3ec9c
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: bb4064d0af8174b6ae247cdad9378b7f4e5f22ba
    Original-Change-Id: I105ea97f8862b5707b582904c6f2e3e9406a0f07
    Original-Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/340428
    Original-Reviewed-by: Patrick Georgi <patrick at georgi-clan.de>
    Reviewed-on: https://review.coreboot.org/14722
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See https://review.coreboot.org/14722 for details.

-gerrit



More information about the coreboot-gerrit mailing list