[coreboot-gerrit] Patch merged into coreboot/master: rockchip: rk3399: use static pointers to regs as they compile to faster code

gerrit at coreboot.org gerrit at coreboot.org
Mon May 9 08:41:10 CEST 2016


the following patch was just integrated into master:
commit b38895ea38e1b2d35eed16d8dd8bfb48f0af1ff5
Author: Vadim Bendebury <vbendeb at chromium.org>
Date:   Wed Apr 20 15:17:24 2016 -0700

    rockchip: rk3399: use static pointers to regs as they compile to faster code
    
    Quoting an earlier review comment, using static structures pointers in
    the include file "should allow the compiler to optimize accesses
    better than defining it in a separate compilation unit (by being able
    to constant fold stuff like &rk3399_pmusgrf->field into a single
    address, rather than loading the symbol, loading an offset constant
    and adding)".
    
    Any decent compiler linker system nowadays would consolidate this
    definition in any case.
    
    BRANCH=none
    BUG=chrome-os-partner:51537
    TEST=with the rest of the patches applied Kevin successfully boots
         Linux kernel.
    
    Change-Id: Ibb576c7691a30f2f429651fcca133bd72710c13b
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 89b6f22e37f733667156f15afb8c27d8a9f07512
    Original-Change-Id: Ice8d6d766a91e7f4fce553378a23b9ca593d12dd
    Original-Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/339869
    Original-Reviewed-by: Julius Werner <jwerner at chromium.org>
    Reviewed-on: https://review.coreboot.org/14705
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See https://review.coreboot.org/14705 for details.

-gerrit



More information about the coreboot-gerrit mailing list