[coreboot-gerrit] Patch set updated for coreboot: lint: Update board status script to look at the whole tree
Martin Roth (martinroth@google.com)
gerrit at coreboot.org
Tue Mar 29 23:19:07 CEST 2016
Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14118
-gerrit
commit 7e4f4bbf326d34f5d6e41e060cbfd633f713ca0a
Author: Martin Roth <martinroth at google.com>
Date: Wed Mar 16 15:58:23 2016 -0600
lint: Update board status script to look at the whole tree
The board status script wasn't checking the entire tree to make sure
that all boards had board_info.txt files. Also it would only print
out the first issue that was found.
Change-Id: I5f2fa9e564c805c6dbee7a35cab80c1c342567a5
Signed-off-by: Martin Roth <martinroth at google.com>
---
util/lint/lint-stable-005-board-status | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/util/lint/lint-stable-005-board-status b/util/lint/lint-stable-005-board-status
index 61813ea..952a9b5 100755
--- a/util/lint/lint-stable-005-board-status
+++ b/util/lint/lint-stable-005-board-status
@@ -16,11 +16,11 @@
# DESCR: Check that every board has a meaningful board_info.txt
LC_ALL=C export LC_ALL
-for mobodir in $(git diff --diff-filter ACMR --name-only src/mainboard | sed -n 's,^\(src/mainboard/[^/]*/[^/]*\)/.*$,\1,p'|sort|uniq); do
+for mobodir in $(git ls-files src/mainboard | sed -n 's,^\(src/mainboard/[^/]*/[^/]*\)/.*$,\1,p'|sort|uniq); do
board_info="$mobodir/board_info.txt"
if ! [ -f "$board_info" ]; then
echo "No $board_info found"
- exit 1
+ continue
fi
category="$(sed -n 's#^Category: \(.*\)$#\1#p' < "$board_info")"
case "$category" in
@@ -28,11 +28,11 @@ for mobodir in $(git diff --diff-filter ACMR --name-only src/mainboard | sed -n
;;
"")
echo "$board_info doesn't contain 'Category' tag"
- exit 1
+ continue
;;
*)
echo "$board_info specifies unknown category '$category'"
- exit 1
+ continue
;;
esac
done
More information about the coreboot-gerrit
mailing list