[coreboot-gerrit] New patch to review for coreboot: mainboard/kunimitsu: Do google_chromeec_early_init in verstage
Subrata Banik (subrata.banik@intel.com)
gerrit at coreboot.org
Fri Jul 22 15:26:09 CEST 2016
Subrata Banik (subrata.banik at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15788
-gerrit
commit 7808e0f56bad018ef742d8b1ac343a7b3d78c2e6
Author: Subrata Banik <subrata.banik at intel.com>
Date: Fri Jul 22 01:18:36 2016 +0530
mainboard/kunimitsu: Do google_chromeec_early_init in verstage
EC code is compiled for versatge and google_chromeec_early_init
can't be called from bootblock, hence moving it to verstage.
BUG=chrome-os-partner:55357
BRANCH=none
TEST=Build and ensure EC getting programmed in recovery mode.
Change-Id: I8b02b4aeb3ad1922bd3119310867ba45e218e8aa
Signed-off-by: Barnali Sarkar <barnali.sarkar at intel.com>
Signed-off-by: Naveen Krishna Chatradhi <naveenkrishna.ch at intel.com>
Signed-off-by: Subrata Banik <subrata.banik at intel.com>
---
src/mainboard/intel/kunimitsu/Makefile.inc | 2 ++
src/mainboard/intel/kunimitsu/verstage.c | 24 ++++++++++++++++++++++++
2 files changed, 26 insertions(+)
diff --git a/src/mainboard/intel/kunimitsu/Makefile.inc b/src/mainboard/intel/kunimitsu/Makefile.inc
index 1561b24..832371b 100644
--- a/src/mainboard/intel/kunimitsu/Makefile.inc
+++ b/src/mainboard/intel/kunimitsu/Makefile.inc
@@ -22,6 +22,8 @@ romstage-y += boardid.c
romstage-y += pei_data.c
verstage-$(CONFIG_CHROMEOS) += chromeos.c
+verstage-$(CONFIG_SEPARATE_VERSTAGE) += verstage.c
+
romstage-$(CONFIG_CHROMEOS) += chromeos.c
ramstage-$(CONFIG_CHROMEOS) += chromeos.c
diff --git a/src/mainboard/intel/kunimitsu/verstage.c b/src/mainboard/intel/kunimitsu/verstage.c
new file mode 100644
index 0000000..fcfaf3d
--- /dev/null
+++ b/src/mainboard/intel/kunimitsu/verstage.c
@@ -0,0 +1,24 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2016 Intel Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#include <ec/google/chromeec/ec.h>
+#include <vendorcode/google/chromeos/chromeos.h>
+
+void verstage_mainboard_init(void)
+{
+ /* Ensure the EC and PD are in the right mode for recovery */
+ if (IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC))
+ google_chromeec_early_init();
+}
More information about the coreboot-gerrit
mailing list