[coreboot-gerrit] New patch to review for coreboot: soc/intel/apollolake: die() when FSP silicon init fails

[Aaron Durbin (adurbin@chromium.org)]

Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15766

-gerrit

commit 8bbf46a760d24ae50d24cdc11a53043d8f87d6af
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Wed Jul 20 14:58:45 2016 -0500

    soc/intel/apollolake: die() when FSP silicon init fails
    
    The reset requests are handled in the FSP 2.0 wrapper, but
    the current code doesn't check any non-succesful return
    values. Provide parity with the memory init path which die()s
    under those circumstances.
    
    Change-Id: I9df61323f742b4e94294321e3ca3ab58a68ca4dd
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 src/soc/intel/apollolake/chip.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c
index 60cdb50..c71e59a 100644
--- a/src/soc/intel/apollolake/chip.c
+++ b/src/soc/intel/apollolake/chip.c
@@ -201,7 +201,8 @@ static void soc_init(void *data)
 	 * default policy that doesn't honor boards' requirements. */
 	itss_snapshot_irq_polarities(GPIO_IRQ_START, GPIO_IRQ_END);
 
-	fsp_silicon_init();
+	if (fsp_silicon_init() != FSP_SUCCESS)
+		die("FSP silicon init failed. Giving up.");
 
 	/* Restore GPIO IRQ polarities back to previous settings. */
 	itss_restore_irq_polarities(GPIO_IRQ_START, GPIO_IRQ_END);