[coreboot-gerrit] New patch to review for coreboot: Makefile: Use CHROMEEC_SOURCE with fallback instead of hardcoding path

Paul Kocialkowski (contact@paulk.fr) gerrit at coreboot.org
Wed Jul 20 18:40:36 CEST 2016


Paul Kocialkowski (contact at paulk.fr) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15765

-gerrit

commit c633cd955561f932f81cfa65cb218011684501ff
Author: Paul Kocialkowski <contact at paulk.fr>
Date:   Wed Jul 20 18:38:54 2016 +0200

    Makefile: Use CHROMEEC_SOURCE with fallback instead of hardcoding path
    
    This introduces a CHROMEEC_SOURCE variable used for indicating the CrOS
    EC source path, with a fallback to 3rdparty/chromeec.
    
    This allows specifying an external path for the CrOS EC source path.
    
    Change-Id: I9792c7f21597127a385b961b65a00d44cfa37146
    Signed-off-by: Paul Kocialkowski <contact at paulk.fr>
---
 Makefile                            | 1 +
 src/ec/google/chromeec/Makefile.inc | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index fc3845e..7830efa 100644
--- a/Makefile
+++ b/Makefile
@@ -51,6 +51,7 @@ export objk := $(objutil)/kconfig
 absobj := $(abspath $(obj))
 
 VB_SOURCE ?= 3rdparty/vboot
+CHROMEEC_SOURCE ?= 3rdparty/chromeec
 
 export KCONFIG_AUTOHEADER := $(obj)/config.h
 export KCONFIG_AUTOCONFIG := $(obj)/auto.conf
diff --git a/src/ec/google/chromeec/Makefile.inc b/src/ec/google/chromeec/Makefile.inc
index 58f8b6b..a916dc9 100644
--- a/src/ec/google/chromeec/Makefile.inc
+++ b/src/ec/google/chromeec/Makefile.inc
@@ -54,7 +54,7 @@ pdrw.hash-name := pdrw.hash
 pdrw.hash-type := raw
 
 $(obj)/mainboard/$(MAINBOARDDIR)/ecrw:
-	$(MAKE) -C $(top)/3rdparty/chromeec \
+	$(MAKE) -C $(CHROMEEC_SOURCE) \
 		out=$(abspath $(obj)/external/chromeec/$(CONFIG_EC_GOOGLE_CHROMEEC_BOARDNAME)) \
 		CROSS_COMPILE=$(subst -cpp,-,$(CPP_arm)) \
 		HOST_CROSS_COMPILE= \
@@ -63,7 +63,7 @@ $(obj)/mainboard/$(MAINBOARDDIR)/ecrw:
 	cp $(obj)/external/chromeec/$(CONFIG_EC_GOOGLE_CHROMEEC_BOARDNAME)/RW/ec.RW.flat $@
 
 $(obj)/mainboard/$(MAINBOARDDIR)/pdrw:
-	$(MAKE) -C $(top)/3rdparty/chromeec \
+	$(MAKE) -C $(CHROMEEC_SOURCE) \
 		out=$(abspath $(obj)/external/chromeec/$(CONFIG_EC_GOOGLE_CHROMEEC_PD_BOARDNAME)) \
 		CROSS_COMPILE=$(subst -cpp,-,$(CPP_arm)) \
 		HOST_CROSS_COMPILE= \



More information about the coreboot-gerrit mailing list