[coreboot-gerrit] Patch merged into coreboot/master: soc/intel/quark: Fix legacy GPIO reads

gerrit at coreboot.org gerrit at coreboot.org
Wed Jul 20 17:08:06 CEST 2016


the following patch was just integrated into master:
commit b0672402ecedc7c8ca2e634437c603d73aebf471
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Mon Jul 18 10:39:55 2016 -0700

    soc/intel/quark: Fix legacy GPIO reads
    
    Add missing break to LEG_GPIO_REGS case to return the correct value for
    legacy GPIO reads.  Fixes coverity issue CID 1357460.
    
    Found by Coverity, Fixes:
    * CID 1357460 (#1 of 1): Unused value (UNUSED_VALUE)
      returned_value: Assigning value from reg_legacy_gpio_read(step->reg)
      to value here, but that stored value is overwritten before it can be
      used.
    
      value_overwrite: Overwriting previous write to value with value from
      reg_pcie_afe_read(step->reg).
    
    TEST=Build and run on Galileo Gen2.
    
    Change-Id: I6c52e8801a32f510ac94276fe0c097850cbfde57
    Signed-off-by: Lee Leahy <leroy.p.leahy at intel.com>
    Reviewed-on: https://review.coreboot.org/15732
    Tested-by: build bot (Jenkins)
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-by: Martin Roth <martinroth at google.com>


See https://review.coreboot.org/15732 for details.

-gerrit



More information about the coreboot-gerrit mailing list