[coreboot-gerrit] New patch to review for coreboot: nb/intel/x4x: Fix CAS latency detection

[Damien Zammit (damien@zamaudio.com)]

Damien Zammit (damien at zamaudio.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15726

-gerrit

commit 65741954d43de7e6fb3e152794fd7c7d4595c27a
Author: Damien Zammit <damien at zamaudio.com>
Date:   Sun Jul 17 18:26:18 2016 +1000

    nb/intel/x4x: Fix CAS latency detection
    
    Fix and use the failsafe CAS detection logic rather than
    recalulating the values from raw SPDs.
    
    Tested on GA-G41M-ES2L with 2x2GB DDR2-800 dimms
    
    Change-Id: I6af0f1705d099f7bcbff8c9baa94a68dae689e01
    Signed-off-by: Damien Zammit <damien at zamaudio.com>
---
 src/northbridge/intel/x4x/raminit.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/northbridge/intel/x4x/raminit.c b/src/northbridge/intel/x4x/raminit.c
index 5d341db..0f2f184 100644
--- a/src/northbridge/intel/x4x/raminit.c
+++ b/src/northbridge/intel/x4x/raminit.c
@@ -111,10 +111,10 @@ static void sdram_read_spds(struct sysinfo *s)
 			s->dimms[i].chip_capacity = s->dimms[i].banks;
 			s->dimms[i].rows = s->dimms[i].spd_data[3];// - 12;
 			s->dimms[i].cols = s->dimms[i].spd_data[4];// - 9;
-			s->dimms[i].cas_latencies = 0x78;
+			s->dimms[i].cas_latencies = 0x70; // 6,5,4 CL
 			s->dimms[i].cas_latencies &= s->dimms[i].spd_data[18];
 			if (s->dimms[i].cas_latencies == 0)
-				s->dimms[i].cas_latencies = 7;
+				s->dimms[i].cas_latencies = 0x70;
 			s->dimms[i].tAAmin = s->dimms[i].spd_data[26];
 			s->dimms[i].tCKmin = s->dimms[i].spd_data[25];
 			s->dimms[i].width = (s->dimms[i].spd_data[13] >> 3) - 1;
@@ -337,10 +337,10 @@ static void sdram_detect_ram_speed(struct sysinfo *s)
 		// Choose max memory frequency for MCH as previously detected
 		freq = (s->max_ddr2_mhz == 800) ? MEM_CLOCK_800MHz : MEM_CLOCK_667MHz;
 
-		// Detect a common CAS latency
-		commoncas = 0xff;
+		// Detect a common CAS latency (choosing from 6,5,4 CL)
+		commoncas = 0x70;
 		FOR_EACH_POPULATED_DIMM(s->dimms, i) {
-			commoncas &= s->dimms[i].spd_data[18];
+			commoncas &= s->dimms[i].cas_latencies;
 		}
 		if (commoncas == 0) {
 			die("No common CAS among dimms\n");