[coreboot-gerrit] Patch merged into coreboot/master: intel/skylake: Fix issues found by klockwork

gerrit at coreboot.org gerrit at coreboot.org
Tue Jan 19 17:23:49 CET 2016


the following patch was just integrated into master:
commit a1b3547f0f6e08ad2c83c0224e375217bf187120
Author: Naresh G Solanki <Naresh.Solanki at intel.com>
Date:   Fri Dec 11 18:13:02 2015 +0530

    intel/skylake: Fix issues found by klockwork
    
    src/soc/intel/skylake/acpi.c
      Function cbmem_find may return NULL, check before using its result.
    
    src/soc/intel/skylake/flash_controller.c
      Remove dead code: spi_claim_bus is a no-op, always returning 0.
    
    src/soc/intel/skylake/gpio.c
      Check for NULL before using pointers.
    
    src/soc/intel/skylake/igd.c
      Don't copy 0-termination of signature string.
    
    src/soc/intel/skylake/lpc.c
      Don't check unsigned >= 0.
    
    src/soc/intel/skylake/systemagent.c
      Explicitly cast result to 64bit.
    
    BRANCH=None
    BUG=chrome-os-partner:48542
    TEST=Built & booted Kunimitsu board.
    
    Change-Id: I6cbf4f78382383d3c8c3b15f66c5898ab5bf183a
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: d98a8cdd3d095a6943c0e104cd4938639a62bd14
    Original-Change-Id: Id2a31402618f4c9f6f53525ebcf6b71fd67428db
    Original-Signed-off-by: Naresh G Solanki <Naresh.Solanki at intel.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/317522
    Original-Commit-Ready: Naresh Solanki <naresh.solanki at intel.com>
    Original-Tested-by: Naresh Solanki <naresh.solanki at intel.com>
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: https://review.coreboot.org/12991
    Reviewed-by: Martin Roth <martinroth at google.com>
    Tested-by: build bot (Jenkins)


See https://review.coreboot.org/12991 for details.

-gerrit



More information about the coreboot-gerrit mailing list