[coreboot-gerrit] New patch to review for coreboot: google/chell: Adjust nuvoton 8825 button thresholds, add properties

[Patrick Georgi (pgeorgi@google.com)]

Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13013

-gerrit

commit 2a3753aac85227aa70c03db7aaf5924f2698b1a9
Author: Benson Leung <bleung at chromium.org>
Date:   Thu Jan 14 13:08:17 2016 -0800

    google/chell: Adjust nuvoton 8825 button thresholds, add properties
    
    Set "nuvoton,sar-threshold" property to thresholds
    based on tuning with the Android Wired Headphone
    Compatibility Kit and Chell EVT.
    
    Also set properties nuvoton,sar-compare-time and
    nuvoton,sar-sampling-time.
    
    The values of compare and sampling time align with
    the ones from this CL:
    https://chromium-review.googlesource.com/306372
    
    Signed-off-by: Benson Leung <bleung at chromium.org>
    
    BUG=chrome-os-partner:49333
    BRANCH=none
    TEST=Run evtest, selecting the input event for sklnau8825adi
    Using the Nominal headphones from the kit, check that the
    buttons for "KEY_VOLUMEDOWN", "KEY_VOLUMEUP", "KEY_MEDIA",
    and code 582 (?) (should be voice search, but evtest doesn't understand)
    All of these buttons should work properly.
    
    Change-Id: I43dc1957f7d95744f41039a306d323806e66c56a
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 2bb545500afeb5b4fa0d1cd02dbf6453f19901ab
    Original-Change-Id: I126aae1e5ed1b9e1a2429e8c94fe08b3ba3ca736
    Original-Reviewed-on: https://chromium-review.googlesource.com/322243
    Original-Commit-Ready: Benson Leung <bleung at chromium.org>
    Original-Tested-by: Benson Leung <bleung at chromium.org>
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
 src/mainboard/google/chell/acpi/mainboard.asl | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/google/chell/acpi/mainboard.asl b/src/mainboard/google/chell/acpi/mainboard.asl
index 319e0b8..0714582 100644
--- a/src/mainboard/google/chell/acpi/mainboard.asl
+++ b/src/mainboard/google/chell/acpi/mainboard.asl
@@ -165,11 +165,17 @@ Scope (\_SB.PCI0.I2C4)
 				 * Android specification
 				 */
 				Package () {"nuvoton,sar-threshold-num", 4},
+				/*
+				 * Thresholds determined using the Wired Headphone
+				 * Compatibility Kit and a Chell EVT
+				 */
 				Package () {"nuvoton,sar-threshold",
-					Package () {0xc, 0x1e, 0x38, 0x60}},
+					Package () {0x20, 0x32, 0x50, 0x70}},
 				Package () {"nuvoton,sar-hysteresis", 1},
 				/* VDDA for button impedance measurement */
 				Package () {"nuvoton,sar-voltage", 0},
+				Package () {"nuvoton,sar-compare-time", 0 },
+				Package () {"nuvoton,sar-sampling-time", 0 },
 				/* 100ms short key press debounce */
 				Package () {"nuvoton,short-key-debounce", 2},
 				/* 2^(7+2) = 512 ms insert/eject debounce */