[coreboot-gerrit] New patch to review for coreboot: intel/skylake: do not save MRC data in recovery mode

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Fri Jan 15 16:45:23 CET 2016


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13001

-gerrit

commit a6472ce8edcf806caeaea04a540aab639099ce4b
Author: haridhar <haridhar.kalvala at intel.com>
Date:   Fri Dec 18 10:50:46 2015 +0530

    intel/skylake: do not save MRC data in recovery mode
    
    If the system is in recovery don't bother saving MRC training data.
    
    BRANCH=None
    BUG=chrome-os-partner:48534
    TEST=Built for kunimitsu.
    Results show MRC data is not saved
    in recovery mode.
    
    Change-Id: I236b7fe1860ac86722562c9a749067496dfe98f8
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: acca68bb5fece58549d762bfaef3e9f2eb0d3066
    Original-Change-Id: Idb0cd7d7c789a58d05160968f6448cb59882056c
    Original-Signed-off-by: haridhar <haridhar.kalvala at intel.com>
    Original-Signed-off-by: Somayaji, Vishwanath <vishwanath.somayaji at intel.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/319221
    Original-Commit-Ready: Haridhar Kalvala <haridhar.kalvala at intel.com>
    Original-Tested-by: Haridhar Kalvala <haridhar.kalvala at intel.com>
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Original-Reviewed-by: Subrata Banik <subrata.banik at intel.com>
    Original-Reviewed-by: Haridhar Kalvala <haridhar.kalvala at intel.com>
---
 src/drivers/intel/fsp1_1/raminit.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/drivers/intel/fsp1_1/raminit.c b/src/drivers/intel/fsp1_1/raminit.c
index a19f6ae..2ba77e3 100644
--- a/src/drivers/intel/fsp1_1/raminit.c
+++ b/src/drivers/intel/fsp1_1/raminit.c
@@ -24,6 +24,7 @@
 #include <soc/romstage.h>
 #include <string.h>
 #include <timestamp.h>
+#include <bootmode.h>
 
 void raminit(struct romstage_params *params)
 {
@@ -287,7 +288,8 @@ void raminit(struct romstage_params *params)
 	if (mrc_hob == NULL)
 		printk(BIOS_DEBUG,
 			"Memory Configuration Data Hob not present\n");
-	else {
+	else if (!recovery_mode_enabled()) {
+		/* Do not save MRC data in recovery path */
 		pei_ptr->data_to_save = GET_GUID_HOB_DATA(mrc_hob);
 		pei_ptr->data_to_save_size = ALIGN(
 			((u32)GET_HOB_LENGTH(mrc_hob)), 16);



More information about the coreboot-gerrit mailing list