[coreboot-gerrit] Patch set updated for coreboot: xcompile: use $() instead of backticks

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Wed Jan 6 17:09:45 CET 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12843

-gerrit

commit b247715d8647a6e6368b2c25bbc6e586fb5813bf
Author: Martin Roth <martinroth at google.com>
Date:   Tue Jan 5 15:44:02 2016 -0700

    xcompile: use $() instead of backticks
    
    While the backtick syntax isn't actually deprecated, the $() syntax
    is preferred.  Since both styles were being used in this script, settle
    on the new standard for all cases.
    
    Change-Id: I33770d666781b4fa34c909411e0d220c2540dbb4
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 util/xcompile/xcompile | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile
index c8cf6e9..b336f88 100755
--- a/util/xcompile/xcompile
+++ b/util/xcompile/xcompile
@@ -19,15 +19,15 @@ TMPFILE=""
 XGCCPATH=$1
 
 # libpayload crossgcc path
-if [ -d "`pwd`/../../util/crossgcc/xgcc/bin/" ]
+if [ -d "$(pwd)/../../util/crossgcc/xgcc/bin/" ]
 then
-	XGCCPATH=${XGCCPATH:-"`pwd`/../../util/crossgcc/xgcc/bin/"}
+	XGCCPATH=${XGCCPATH:-"$(pwd)/../../util/crossgcc/xgcc/bin/"}
 fi
 
 # coreboot crossgcc path
-if [ -d "`pwd`/util/crossgcc/xgcc/bin/" ]
+if [ -d "$(pwd)/util/crossgcc/xgcc/bin/" ]
 then
-	XGCCPATH=${XGCCPATH:-"`pwd`/util/crossgcc/xgcc/bin/"}
+	XGCCPATH=${XGCCPATH:-"$(pwd)/util/crossgcc/xgcc/bin/"}
 fi
 
 die() {
@@ -187,9 +187,9 @@ detect_special_flags() {
 
 detect_compiler_runtime() {
 	test -z "$CLANG" || \
-	CC_RT_CLANG="`${CLANG} ${CFLAGS_CLANG} -print-librt-file-name 2>/dev/null`"
+	CC_RT_CLANG="$(${CLANG} ${CFLAGS_CLANG} -print-librt-file-name 2>/dev/null)"
 	test -z "$GCC" || \
-	CC_RT_GCC="`${GCC} ${CFLAGS_GCC} -print-libgcc-file-name`"
+	CC_RT_GCC="$(${GCC} ${CFLAGS_GCC} -print-libgcc-file-name)"
 }
 
 report_arch_toolchain() {



More information about the coreboot-gerrit mailing list