[coreboot-gerrit] Patch merged into coreboot/master: drivers/spi: fix flash writes at page boundaries

gerrit at coreboot.org gerrit at coreboot.org
Mon Dec 19 22:34:56 CET 2016


the following patch was just integrated into master:
commit 41f669023953b3d032078ffc17d80944880d1db7
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Sat Dec 17 13:16:07 2016 -0600

    drivers/spi: fix flash writes at page boundaries
    
    There was an assumption that all SPI controllers could
    consume a full page of data to write. However, that
    assumption doesn't hold when spi_crop_chunk() indicates
    sizes smaller than page size. If the requested offset isn't
    page aligned from the start then writes will fail corrupting
    data since a page boundary isn't honored.
    
    The spansion driver needed quite a bit more work to honor
    the spi_crop_chunk() result. It now mimics the other
    driver's code. Also, needed to add spi_crop_chunk() to
    marvell/bg4cd SoC to make google/cosmos build. SPI obviously
    doesn't work on that platform, but it fixes the build error.
    
    Change-Id: I93e24a5a717adcee45a017c164bd960f4592ad50
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: https://review.coreboot.org/17910
    Tested-by: build bot (Jenkins)
    Reviewed-by: Matt DeVillier <matt.devillier at gmail.com>
    Reviewed-by: Kyösti Mälkki <kyosti.malkki at gmail.com>


See https://review.coreboot.org/17910 for details.

-gerrit



More information about the coreboot-gerrit mailing list