[coreboot-gerrit] New patch to review for coreboot: util/romcc: Move access after NULL-check

[Patrick Georgi (pgeorgi@google.com)]

Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17884

-gerrit

commit 9775992654b87e229b6b2bd10b2035eff6981fd3
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Thu Dec 15 15:14:59 2016 +0100

    util/romcc: Move access after NULL-check
    
    Change-Id: I7f9c38fd6e75b32fe1ed8a60c7054f4dd1fcd5c0
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Found-by: Coverity Scan #1129104
---
 util/romcc/romcc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/romcc/romcc.c b/util/romcc/romcc.c
index 9a90167..655e6f5 100644
--- a/util/romcc/romcc.c
+++ b/util/romcc/romcc.c
@@ -6287,10 +6287,10 @@ static size_t field_reg_offset(struct compile_state *state,
 		internal_error(state, 0, "field_reg_offset only works on structures and unions");
 	}
 
-	size += reg_needed_padding(state, member, size);
 	if (!member || (member->field_ident != field)) {
 		error(state, 0, "member %s not present", field->name);
 	}
+	size += reg_needed_padding(state, member, size);
 	return size;
 }