[coreboot-gerrit] New patch to review for coreboot: util/romcc: Fix resource leak

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Thu Dec 15 15:25:43 CET 2016


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17883

-gerrit

commit 25cad2ec8453a78b65d5335e9658e50e5e02a9c3
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Thu Dec 15 15:12:16 2016 +0100

    util/romcc: Fix resource leak
    
    Change-Id: I0d260254bab714ec939fc199b3a133b0fc05b10d
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Found-by: Coverity Scan #1129112
---
 util/romcc/romcc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/util/romcc/romcc.c b/util/romcc/romcc.c
index c97312c..9a90167 100644
--- a/util/romcc/romcc.c
+++ b/util/romcc/romcc.c
@@ -10779,6 +10779,7 @@ static struct triple *string_constant(struct compile_state *state)
 		ptr = buf;
 		buf = xmalloc(type->elements + str_len + 1, "string_constant");
 		memcpy(buf, ptr, type->elements);
+		free(ptr);
 		ptr = buf + type->elements;
 		do {
 			*ptr++ = char_value(state, &str, end);



More information about the coreboot-gerrit mailing list