[coreboot-gerrit] New patch to review for coreboot: util/broadcom: Initialize variable

[Patrick Georgi (pgeorgi@google.com)]

Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17880

-gerrit

commit f025a5c4ae1bb4aa4452279da4c896f468adda86
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Thu Dec 15 14:59:37 2016 +0100

    util/broadcom: Initialize variable
    
    It's later tested for NULL, but never initialized to make that test work
    reliably.
    
    Change-Id: Iadee1af224507a6dd39956306f3eafa687895176
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Found-by: Coverity Scan #1323515
---
 util/broadcom/secimage/sbi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/util/broadcom/secimage/sbi.c b/util/broadcom/secimage/sbi.c
index 58d4a39..8718f14 100644
--- a/util/broadcom/secimage/sbi.c
+++ b/util/broadcom/secimage/sbi.c
@@ -77,12 +77,12 @@ int AddImagePayload(char *h, char *filename, unsigned int filesize)
  *---------------------------------------------------------------------*/
 int CreateSecureBootImage(int ac, char **av)
 {
-	char *outfile, *configfile, *arg, *privkey = NULL, *bl = NULL;
+	char *configfile = NULL, *arg, *privkey = NULL, *bl = NULL;
 	int status = 0;
 	uint32_t sbiLen;
 	struct stat file_stat;
 	uint32_t add_header = 1;
-	outfile = *av;
+	char *outfile = *av;
 	unsigned int filesize;
 	char *buf;
 	--ac; ++av;