[coreboot-gerrit] New patch to review for coreboot: util/broadcom: Close file after use

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Thu Dec 15 15:04:58 CET 2016


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17879

-gerrit

commit af356203e898a3ccb2f1da5d9e8fb04b54a394a1
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Thu Dec 15 14:57:04 2016 +0100

    util/broadcom: Close file after use
    
    Change-Id: Ieea7ac7fbc618cd12f843f1606f9ebab37cae67e
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Found-by: Coverity Scan #1323508
---
 util/broadcom/secimage/misc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/util/broadcom/secimage/misc.c b/util/broadcom/secimage/misc.c
index fa9f8c5..0d0cf0b 100644
--- a/util/broadcom/secimage/misc.c
+++ b/util/broadcom/secimage/misc.c
@@ -53,5 +53,6 @@ void FillHeaderFromConfigFile(char *h, char *ConfigFileName)
 				h1->Reserved = Reserved;
 			}
 		}
+		fclose(fp);
 	}
 }



More information about the coreboot-gerrit mailing list