[coreboot-gerrit] New patch to review for coreboot: [WIP] Makefile.inc: Give an error if CBFS_SIZE > ROM_SIZE

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Tue Dec 13 00:48:25 CET 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17808

-gerrit

commit e18e0684b48a99f42c1fecaa1d9aa67998204403
Author: Martin Roth <martinroth at google.com>
Date:   Mon Dec 12 16:48:08 2016 -0700

    [WIP] Makefile.inc: Give an error if CBFS_SIZE > ROM_SIZE
    
    Change-Id: I84d2185f222617f88147eaf0ffb14ad67089860e
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 Makefile.inc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Makefile.inc b/Makefile.inc
index c5ce30f..8f8706a 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -793,6 +793,9 @@ FMAP_FMAP_SIZE := 0x100
 # position and size of CBFS, relative to BIOS_BASE
 FMAP_CBFS_BASE := $(FMAP_FMAP_SIZE)
 FMAP_CBFS_SIZE := $(call int-subtract, $(FMAP_BIOS_SIZE) $(FMAP_FMAP_SIZE))
+ifeq ($(findstring -,$(FMAP_BIOS_BASE)),-)
+$(error ERROR: CBFS_SIZE is greater than ROM_SIZE: $(CONFIG_CBFS_SIZE) > $(CONFIG_ROM_SIZE) )
+endif
 else # ifeq ($(CONFIG_ARCH_X86),y)
 DEFAULT_FLASHMAP:=$(top)/util/cbfstool/default.fmd
 # entire flash



More information about the coreboot-gerrit mailing list