[coreboot-gerrit] New patch to review for coreboot: checkpatch.pl: ignore '#define asmlinkage'

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Tue Aug 30 17:40:13 CEST 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16358

-gerrit

commit 10376b39edfd559094d79f0ebd44636f23478ee3
Author: Martin Roth <martinroth at google.com>
Date:   Mon Aug 29 15:32:10 2016 -0600

    checkpatch.pl: ignore '#define asmlinkage'
    
    checkpatch warns that the asmlinkage storage class should be at the
    beginning of the declaration when we define it to be an empty value.
    
    Change-Id: I12292d5b42bf6da9130bb969ebe00fca8efcf049
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 util/lint/checkpatch.pl | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/util/lint/checkpatch.pl b/util/lint/checkpatch.pl
index 646cb0f..84574f1 100755
--- a/util/lint/checkpatch.pl
+++ b/util/lint/checkpatch.pl
@@ -5340,7 +5340,8 @@ sub process {
 		}
 
 # Check that the storage class is at the beginning of a declaration
-		if ($line =~ /\b$Storage\b/ && $line !~ /^.\s*$Storage\b/) {
+# coreboot: skip complaint about our '#define asmlinkage' lines
+		if ($line =~ /\b$Storage\b/ && $line !~ /^.\s*$Storage\b/ && $line !~ /^.\s*#\s*define\s+$Storage\b/) {
 			WARN("STORAGE_CLASS",
 			     "storage class should be at the beginning of the declaration\n" . $herecurr)
 		}



More information about the coreboot-gerrit mailing list