[coreboot-gerrit] New patch to review for coreboot: checkpatch.pl: Force raw_line to return a defined value
Martin Roth (martinroth@google.com)
gerrit at coreboot.org
Tue Aug 30 17:40:12 CEST 2016
Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16357
-gerrit
commit a5aba673a94b18f310f5b687d7f7874221b08d38
Author: Martin Roth <martinroth at google.com>
Date: Mon Aug 29 15:30:23 2016 -0600
checkpatch.pl: Force raw_line to return a defined value
Fixes the warning:
Use of uninitialized value in concatenation (.) or string at
util/lint/checkpatch.pl line 4739
Change-Id: Idc3c631735a595517d77cb8b8ec67e1ac00b6685
Signed-off-by: Martin Roth <martinroth at google.com>
---
util/lint/checkpatch.pl | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/util/lint/checkpatch.pl b/util/lint/checkpatch.pl
index eb03bc7..646cb0f 100755
--- a/util/lint/checkpatch.pl
+++ b/util/lint/checkpatch.pl
@@ -1495,7 +1495,13 @@ sub raw_line {
$cnt--;
}
- return $line;
+ # coreboot: This probably shouldn't happen, but it does.
+ # Return a defined value so we don't get an error.
+ if (defined $line) {
+ return $line;
+ } else {
+ return "";
+ }
}
sub cat_vet {
More information about the coreboot-gerrit
mailing list