[coreboot-gerrit] Patch merged into coreboot/master: mainboard: Clean up boot_option/reboot_bits in cmos.layout

gerrit at coreboot.org gerrit at coreboot.org
Wed Aug 17 00:27:45 CEST 2016


the following patch was just integrated into master:
commit d23ee5de2233d2f200dc15bf4a7669599c2b2014
Author: Nico Huber <nico.h at gmx.de>
Date:   Thu Aug 11 22:45:55 2016 +0200

    mainboard: Clean up boot_option/reboot_bits in cmos.layout
    
    Since commit 3bfd7cc (drivers/pc80: Rework normal / fallback selector
    code) the reboot counter stored in `reboot_bits` isn't reset on a reboot
    with `boot_option = 1` any more. Hence, with SKIP_MAX_REBOOT_CNT_CLEAR
    enabled, later stages (e.g. payload, OS) have to clear the counter too,
    when they want to switch to normal boot. So change the bits to (h)ex
    instead of (r)eserved.
    
    To clarify their meaning, rename `reboot_bits` to `reboot_counter`. Also
    remove all occurences of the obsolete `last_boot` bit that have sneaked
    in again since 24391321 (mainboard: Remove last_boot NVRAM option).
    
    Change-Id: Ib3fc38115ce951b75374e0d1347798b23db7243c
    Signed-off-by: Nico Huber <nico.h at gmx.de>
    Reviewed-on: https://review.coreboot.org/16157
    Tested-by: build bot (Jenkins)
    Reviewed-by: Timothy Pearson <tpearson at raptorengineering.com>
    Reviewed-by: York Yang <york.yang at intel.com>
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>


See https://review.coreboot.org/16157 for details.

-gerrit



More information about the coreboot-gerrit mailing list