[coreboot-gerrit] New patch to review for coreboot: drivers/elog: remove unnecessary check in elog_shrink()
Aaron Durbin (adurbin@chromium.org)
gerrit at coreboot.org
Sat Aug 6 08:32:38 CEST 2016
Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16093
-gerrit
commit 427cd7e0f8895e75cc3378aac38c64ffbaac4b89
Author: Aaron Durbin <adurbin at chromium.org>
Date: Wed Aug 3 23:01:50 2016 -0500
drivers/elog: remove unnecessary check in elog_shrink()
There was a check against the next event offset against
the shrink size in elog_shrink(). However, all calls
to elog_shrink() were conditionalized on the next
event offset exceeding the full threshold. The shrink
size is set to the minimum of the full threshold and
a percentage of the elog region size. Therefore, it's
impossible for the next event offset to be less than
the shrink size because full threshold is always greater
than or equal to the shrink size.
BUG=chrome-os-partner:55932
Change-Id: Ie6ff106f1c53c15aa36a82223a235a7ac97fd8c7
Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
src/drivers/elog/elog.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/drivers/elog/elog.c b/src/drivers/elog/elog.c
index 59bc1de..d8c7ff6 100644
--- a/src/drivers/elog/elog.c
+++ b/src/drivers/elog/elog.c
@@ -352,9 +352,6 @@ static int elog_shrink(void)
elog_debug("elog_shrink()\n");
- if (next_event_offset < shrink_size)
- return 0;
-
while (1) {
/* Next event has exceeded constraints */
if (offset > shrink_size)
More information about the coreboot-gerrit
mailing list