[coreboot-gerrit] New patch to review for coreboot: drivers/elog: use event region size when adding a clear event

Aaron Durbin (adurbin@chromium.org) gerrit at coreboot.org
Sat Aug 6 08:32:36 CEST 2016


Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16092

-gerrit

commit 8a1f012fce00d7aaa21548adceee04e0188ae7ec
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Wed Aug 3 17:32:47 2016 -0500

    drivers/elog: use event region size when adding a clear event
    
    For the elog shrink case we log the number of bytes shrunk
    from the event log. However, when clearing the log the
    size recorded was the entire region size including the header
    as well as the event region space. To be more consistent
    mark the clearing event with the number of bytes actually
    cleared out (excluding the header size).
    
    BUG=chrome-os-partner:55932
    
    Change-Id: I7c33da97bd29a90bfe975b1c6f148f181016f13f
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 src/drivers/elog/elog.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/drivers/elog/elog.c b/src/drivers/elog/elog.c
index 6eacba5..59bc1de 100644
--- a/src/drivers/elog/elog.c
+++ b/src/drivers/elog/elog.c
@@ -469,7 +469,7 @@ int elog_clear(void)
 		return -1;
 
 	/* Log the clear event */
-	elog_add_event_word(ELOG_TYPE_LOG_CLEAR, total_size);
+	elog_add_event_word(ELOG_TYPE_LOG_CLEAR, log_size);
 
 	return 0;
 }
@@ -576,7 +576,7 @@ int elog_init(void)
 
 	/* Log a clear event if necessary */
 	if (event_count == 0)
-		elog_add_event_word(ELOG_TYPE_LOG_CLEAR, total_size);
+		elog_add_event_word(ELOG_TYPE_LOG_CLEAR, log_size);
 
 #if !defined(__SMM__)
 	/* Log boot count event except in S3 resume */



More information about the coreboot-gerrit mailing list