[coreboot-gerrit] New patch to review for coreboot: soc/intel/skylake: Code cleanup of SoC ASL code.

[Barnali Sarkar (barnali.sarkar@intel.com)]

Barnali Sarkar (barnali.sarkar at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16068

-gerrit

commit f035ba38adc8df350b4e0a219110adab42564759
Author: Barnali Sarkar <barnali.sarkar at intel.com>
Date:   Thu Aug 4 17:46:55 2016 +0530

    soc/intel/skylake: Code cleanup of SoC ASL code.
    
    List of changes done here in this patch
    
    1. Remove CARD definition from EMMC and SD Card Controller in scs.asl
    since _RMV method does not gets evaluated while setting up removable
    attribute in sysfs in kernel.
    "cat /sys/block/mmcblk1/removable" this command always returns 0.
    
    This CARD Device includes _ADR which follows SDIO Bus format. But,
    SD/EMMC sits on PCI Bus.
    Hence these CARD Device specific _ADR code is also not needed.
    
    2. Removed Base Address for ACPI debug output memory buffer in
    systemagent.asl as it is not getting used throught the code.
    
    BUG=none
    BRANCH=none
    TEST=Build and boot kunimitsu
    
    Change-Id: I29effaffdafcc21e26445ec3c54aedecdbc50274
    Signed-off-by: Barnali Sarkar <barnali.sarkar at intel.com>
---
 src/soc/intel/skylake/acpi/scs.asl         | 18 ------------------
 src/soc/intel/skylake/acpi/systemagent.asl |  5 -----
 2 files changed, 23 deletions(-)

diff --git a/src/soc/intel/skylake/acpi/scs.asl b/src/soc/intel/skylake/acpi/scs.asl
index 69bc82a..13e8f5d 100644
--- a/src/soc/intel/skylake/acpi/scs.asl
+++ b/src/soc/intel/skylake/acpi/scs.asl
@@ -59,15 +59,6 @@ Device (EMMC)
 		Store (Local0, ^D0D3)
 		Store (^D0D3, Local0)
 	}
-
-	Device (CARD)
-	{
-		Name (_ADR, 0x00000008)
-		Method (_RMV, 0, NotSerialized)
-		{
-			Return (0)
-		}
-	}
 }
 
 #if !IS_ENABLED(CONFIG_EXCLUDE_NATIVE_SD_INTERFACE)
@@ -130,14 +121,5 @@ Device (SDXC)
 		^^PCRO (PID_GPIOCOM3, 0x4e4, 0x00001000)
 		^^PCRO (PID_GPIOCOM3, 0x4f4, 0x00001000)
 	}
-
-	Device (CARD)
-	{
-		Name (_ADR, 0x00000008)
-		Method (_RMV, 0, NotSerialized)
-		{
-			Return (1)
-		}
-	}
 }
 #endif
\ No newline at end of file
diff --git a/src/soc/intel/skylake/acpi/systemagent.asl b/src/soc/intel/skylake/acpi/systemagent.asl
index 842bb70..a04fe9e 100644
--- a/src/soc/intel/skylake/acpi/systemagent.asl
+++ b/src/soc/intel/skylake/acpi/systemagent.asl
@@ -340,11 +340,6 @@ Device (PDRC)
 
 		/* HPET address decode range */
 		Memory32Fixed (ReadWrite, HPET_BASE_ADDRESS, 0x400)
-
-		/* Debug Base Address
-		 * Base Address for ACPI debug output memory buffer
-		 */
-		Memory32Fixed (ReadWrite, 0, 0, DBAD)
 	})
 
 	Method (_CRS, 0, Serialized)