[coreboot-gerrit] New patch to review for coreboot: build system: drop commented out code

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Fri Aug 5 13:12:03 CEST 2016


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16067

-gerrit

commit 3948abe9ef10d57d0cba9f443f0414e45c1829ee
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Fri Aug 5 13:10:39 2016 +0200

    build system: drop commented out code
    
    Change-Id: I7f36a317f0a7cf4634246a255be79e6bcb2b2442
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Found-by: Daisuke Nojiri <dnojiri at chromium.org>
---
 Makefile.inc | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/Makefile.inc b/Makefile.inc
index 71213fe..a6e1fc6 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -726,12 +726,6 @@ ifeq ($(CONFIG_ARCH_X86),y)
 		-t bootblock \
 		-b -$(call file-size,$(objcbfs)/bootblock.bin) $(cbfs-autogen-attributes)
 else # ifeq ($(CONFIG_ARCH_X86),y)
-	# don't add bootblock to cbfs yet, it's just a waste of space
-	true $(CBFSTOOL) $@.tmp add \
-		-f $(objcbfs)/bootblock.bin \
-		-n bootblock \
-		-t bootblock \
-		-b 0
 	$(CBFSTOOL) $@.tmp write -u \
 		-r BOOTBLOCK \
 		-f $(objcbfs)/bootblock.bin



More information about the coreboot-gerrit mailing list