[coreboot-gerrit] Patch merged into coreboot/master: checkpatch: Add BLOCK_COMMENT_STYLE to ignore list
gerrit at coreboot.org
gerrit at coreboot.org
Fri Aug 5 00:02:01 CEST 2016
the following patch was just integrated into master:
commit 6e05c33626e128c383470579f423b1ee569302ba
Author: Julius Werner <jwerner at chromium.org>
Date: Wed Aug 3 20:07:35 2016 -0700
checkpatch: Add BLOCK_COMMENT_STYLE to ignore list
Linux' newest checkpatch.pl flags comments like these:
/* This is a concise 2-line comment that explains what the code does in
* sufficient detail without wasting too much vertical space. */
do_stuff_that_needs_explaining();
Comments like these have been used in our code base for a long time and
I don't think we should disallow them now. Ending the comment on the
same line doesn't really hurt readability and wastes less screen real
estate (which in turn usually helps overall code comprehension).
Change-Id: Ifd57f3d3a62738165024cb4b2e75a4f815a57922
Signed-off-by: Julius Werner <jwerner at chromium.org>
Reviewed-on: https://review.coreboot.org/16060
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
See https://review.coreboot.org/16060 for details.
-gerrit
More information about the coreboot-gerrit
mailing list