[coreboot-gerrit] New patch to review for coreboot: Broadwell: Do not set IRQ3 and IRQ4 to level
Kevin Herbert (kevin@trippers.org)
gerrit at coreboot.org
Thu Aug 4 23:38:10 CEST 2016
Kevin Herbert (kevin at trippers.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16065
-gerrit
commit cf81576b3c782c200cfd6124039c7ff0cfa476c8
Author: Kevin Paul Herbert <kevin at trippers.org>
Date: Thu Aug 4 14:35:30 2016 -0700
Broadwell: Do not set IRQ3 and IRQ4 to level
When booting Linux as a Coreboot payload, serial access does not work
properly. This is because the setup code erroneously sets IRQ3 and
IRQ4 to level. The UART on Broadwell is 8250/16550 compatible, thus
ISA and edge-triggered.
Change-Id: I17b466676e7f4891c3e75ce6208e1580c9eaf742
Signed-off-by: Kevin Paul Herbert <kevin at trippers.org>
---
src/soc/intel/fsp_broadwell_de/acpi.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/src/soc/intel/fsp_broadwell_de/acpi.c b/src/soc/intel/fsp_broadwell_de/acpi.c
index 1e08868..f83eb79 100644
--- a/src/soc/intel/fsp_broadwell_de/acpi.c
+++ b/src/soc/intel/fsp_broadwell_de/acpi.c
@@ -468,15 +468,5 @@ unsigned long acpi_madt_irq_overrides(unsigned long current)
current += acpi_create_madt_irqoverride(irqovr, 0, sci_irq, sci_irq,
sci_flags);
- irqovr = (void *)current;
- current += acpi_create_madt_irqoverride(irqovr, 0, 3, 3,
- (MP_IRQ_TRIGGER_LEVEL
- |MP_IRQ_POLARITY_LOW));
-
- irqovr = (void *)current;
- current += acpi_create_madt_irqoverride(irqovr, 0, 4, 4,
- (MP_IRQ_TRIGGER_LEVEL
- |MP_IRQ_POLARITY_LOW));
-
return current;
}
More information about the coreboot-gerrit
mailing list