[coreboot-gerrit] New patch to review for coreboot: drivers/intel/fsp2_0: Eliminate the back to back MTRR display

[Lee Leahy (leroy.p.leahy@intel.com)]

Lee Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16043

-gerrit

commit a28e84b46085686c9448d4047938988c168882c4
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Tue Aug 2 18:05:54 2016 -0700

    drivers/intel/fsp2_0: Eliminate the back to back MTRR display
    
    Because fsp_notify is being called back to back for READY_TO_BOOT and
    END_OF_FIRMWARE, move the call to soc_display_mtrrs into the
    fsp_notify_dummy routine.  This provides the before display and the
    output in fsp_debug_after_notify provides the after.  The second
    call within fsp_notify_dummy to fsp_notify no longer displays another
    copy of the MTRRs before calling into FSP.
    
    TEST=Build and run on Galileo Gen2
    
    Change-Id: I87c9ae570c272cfaf61a499b5f217380fa1eee03
    Signed-off-by: Lee Leahy <leroy.p.leahy at intel.com>
---
 src/drivers/intel/fsp2_0/debug.c  | 4 ----
 src/drivers/intel/fsp2_0/notify.c | 5 +++++
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/drivers/intel/fsp2_0/debug.c b/src/drivers/intel/fsp2_0/debug.c
index 885509e..218c8a4 100644
--- a/src/drivers/intel/fsp2_0/debug.c
+++ b/src/drivers/intel/fsp2_0/debug.c
@@ -101,10 +101,6 @@ void fsp_debug_after_silicon_init(enum fsp_status status)
 void fsp_before_debug_notify(fsp_notify_fn notify,
 	const struct fsp_notify_params *notify_params)
 {
-	/* Display the MTRRs */
-	if (IS_ENABLED(CONFIG_DISPLAY_MTRRS))
-		soc_display_mtrrs();
-
 	/* Display the call to FspNotify */
 	if (!IS_ENABLED(CONFIG_DISPLAY_FSP_CALLS_AND_STATUS))
 		return;
diff --git a/src/drivers/intel/fsp2_0/notify.c b/src/drivers/intel/fsp2_0/notify.c
index 1513596..9879de0 100644
--- a/src/drivers/intel/fsp2_0/notify.c
+++ b/src/drivers/intel/fsp2_0/notify.c
@@ -15,6 +15,7 @@
 #include <console/console.h>
 #include <fsp/api.h>
 #include <fsp/util.h>
+#include <soc/intel/common/util.h>
 #include <string.h>
 #include <timestamp.h>
 
@@ -65,6 +66,10 @@ static void fsp_notify_dummy(void *arg)
 {
 	enum fsp_notify_phase phase = (uint32_t)arg;
 
+	/* Display the MTRRs */
+	if (IS_ENABLED(CONFIG_DISPLAY_MTRRS))
+		soc_display_mtrrs();
+
 	fsp_notify(phase);
 	if (phase == READY_TO_BOOT)
 		fsp_notify(END_OF_FIRMWARE);