[coreboot-gerrit] Patch set updated for coreboot: soc/intel/quark: Fix MTRR reads

Leroy P Leahy (leroy.p.leahy@intel.com) gerrit at coreboot.org
Thu Apr 21 22:04:56 CEST 2016


Leroy P Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14450

-gerrit

commit 1cade01714206243df537ce85916ff1cb707df60
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Wed Apr 6 10:02:41 2016 -0700

    soc/intel/quark: Fix MTRR reads
    
    Remove offset override improperly added in the "Disable the ROM shadow"
    patch
    
    TEST=Build and run on Galileo Gen2
    
    Change-Id: I32fb2da48e3769d59a49619539053f9afdf63b04
    Signed-off-by: Lee Leahy <leroy.p.leahy at intel.com>
---
 src/soc/intel/quark/romstage/mtrr.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/soc/intel/quark/romstage/mtrr.c b/src/soc/intel/quark/romstage/mtrr.c
index 1528e17..8b237a3 100644
--- a/src/soc/intel/quark/romstage/mtrr.c
+++ b/src/soc/intel/quark/romstage/mtrr.c
@@ -76,7 +76,6 @@ static uint32_t mtrr_index_to_host_bridge_register_offset(unsigned long index)
 uint32_t port_reg_read(uint8_t port, uint32_t offset)
 {
 	/* Read the port register */
-	offset = QNC_MSG_FSBIC_REG_HMISC;
 	mea_write(offset);
 	mcr_write(QUARK_OPCODE_READ, port, offset);
 	return mdr_read();



More information about the coreboot-gerrit mailing list