[coreboot-gerrit] New patch to review for coreboot: intel/fsp_broadwell_de: fix SPD CBFS file type

Stef van Os (stef.van.os@prodrive-technologies.com) gerrit at coreboot.org
Tue Apr 19 14:31:04 CEST 2016


Stef van Os (stef.van.os at prodrive-technologies.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14415

-gerrit

commit dd228ddcbab7c71f64ba323ab474d5edfa697e1f
Author: Stef van Os <stef.van.os at prodrive-technologies.com>
Date:   Tue Apr 19 14:11:11 2016 +0200

    intel/fsp_broadwell_de: fix SPD CBFS file type
    
    File type for SPD in this soc is defined as CBFS_TYPE_RAW in Makefile, but CBFS_TYPE_SPD in code.
    Causes DDR SPD not to be loaded on memory down.
    
    Change-Id: I44525b4742b3f93d33f0c5bd9ed642c6fb06f23f
    Signed-off-by: Stef van Os <stef.van.os at prodrive-technologies.com>
---
 src/soc/intel/fsp_broadwell_de/fsp/chipset_fsp_util.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/soc/intel/fsp_broadwell_de/fsp/chipset_fsp_util.c b/src/soc/intel/fsp_broadwell_de/fsp/chipset_fsp_util.c
index cab4b59..7a9e8f5 100644
--- a/src/soc/intel/fsp_broadwell_de/fsp/chipset_fsp_util.c
+++ b/src/soc/intel/fsp_broadwell_de/fsp/chipset_fsp_util.c
@@ -62,16 +62,16 @@ static void ConfigureDefaultUpdData(UPD_DATA_REGION *UpdData)
 
 		if (IS_ENABLED(CONFIG_FSP_MEMORY_DOWN_CH0DIMM0_SPD_PRESENT))
 			UpdData->MemDownCh0Dimm0SpdPtr
-			= (UINT32)cbfs_boot_map_with_leak("spd_ch0_dimm0.bin", CBFS_TYPE_RAW, NULL);
+			= (UINT32)cbfs_boot_map_with_leak("spd_ch0_dimm0.bin", CBFS_TYPE_SPD, NULL);
 		if (IS_ENABLED(CONFIG_FSP_MEMORY_DOWN_CH0DIMM1_SPD_PRESENT))
 			UpdData->MemDownCh0Dimm1SpdPtr
-			= (UINT32)cbfs_boot_map_with_leak("spd_ch0_dimm1.bin", CBFS_TYPE_RAW, NULL);
+			= (UINT32)cbfs_boot_map_with_leak("spd_ch0_dimm1.bin", CBFS_TYPE_SPD, NULL);
 		if (IS_ENABLED(CONFIG_FSP_MEMORY_DOWN_CH1DIMM0_SPD_PRESENT))
 			UpdData->MemDownCh1Dimm0SpdPtr
-			= (UINT32)cbfs_boot_map_with_leak("spd_ch1_dimm0.bin", CBFS_TYPE_RAW, NULL);
+			= (UINT32)cbfs_boot_map_with_leak("spd_ch1_dimm0.bin", CBFS_TYPE_SPD, NULL);
 		if (IS_ENABLED(CONFIG_FSP_MEMORY_DOWN_CH1DIMM1_SPD_PRESENT))
 			UpdData->MemDownCh1Dimm1SpdPtr
-			= (UINT32)cbfs_boot_map_with_leak("spd_ch1_dimm1.bin", CBFS_TYPE_RAW, NULL);
+			= (UINT32)cbfs_boot_map_with_leak("spd_ch1_dimm1.bin", CBFS_TYPE_SPD, NULL);
 	} else {
 		UpdData->MemDownEnable = 0;
 	}



More information about the coreboot-gerrit mailing list