[coreboot-gerrit] New patch to review for coreboot: intel/apollolake: Fix logic error

[Patrick Georgi (pgeorgi@google.com)]

Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14360

-gerrit

commit e2e59a23cefba95dad3ceb5e5fff292f69cf1046
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Thu Apr 14 11:53:48 2016 +0200

    intel/apollolake: Fix logic error
    
    Testing dev->chip == NULL when dev == NULL doesn't make sense (and gcc
    thinks that's undefined behavior which should be rewarded with a trap).
    
    Change-Id: I801ce3d6b791fdf96b23333432dee394aa2e2ddf
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
---
 src/soc/intel/apollolake/chip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c
index e9eb1ac..c6cc6cf 100644
--- a/src/soc/intel/apollolake/chip.c
+++ b/src/soc/intel/apollolake/chip.c
@@ -76,7 +76,7 @@ void platform_fsp_silicon_init_params_cb(struct FSPS_UPD *silupd)
 	silconfig->GraphicsConfigPtr = fsp_load_vbt();
 
 	struct device *dev = NB_DEV_ROOT;
-	if (!dev && !dev->chip_info) {
+	if (!dev || !dev->chip_info) {
 		printk(BIOS_ERR, "BUG! Could not find SOC devicetree config\n");
 		return;
 	}