[coreboot-gerrit] New patch to review for coreboot: bootblock_crt0: Use CR* macros from cpu/x86/cr.h

Furquan Shaikh (furquan@google.com) gerrit at coreboot.org
Thu Apr 14 02:24:37 CEST 2016


Furquan Shaikh (furquan at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14359

-gerrit

commit 9684e12c6c6b2f5bd61efe65743fa1e8662c60b9
Author: Furquan Shaikh <furquan at google.com>
Date:   Wed Apr 13 17:15:36 2016 -0700

    bootblock_crt0: Use CR* macros from cpu/x86/cr.h
    
    Instead of re-defining the macros, include cpu/x86/cr.h in
    bootblock_crt0.S to re-use already defined macros for accessing CR*
    flags.
    
    Change-Id: Idade02f7a6bc880c9aad3bfacd05ac57b6d04e44
    Signed-off-by: Furquan Shaikh <furquan at google.com>
---
 src/arch/x86/bootblock_crt0.S | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/arch/x86/bootblock_crt0.S b/src/arch/x86/bootblock_crt0.S
index 2ecddba..7292b8b 100644
--- a/src/arch/x86/bootblock_crt0.S
+++ b/src/arch/x86/bootblock_crt0.S
@@ -21,11 +21,7 @@
  * GNU General Public License for more details.
  */
 
-#define CR0_MP		(1 << 1)
-#define CR0_EM		(1 << 2)
-
-#define CR4_OSFXSR	(1 << 9)
-#define CR4_OSXMMEXCPT	(1 << 10)
+#include <cpu/x86/cr.h>
 
 /*
  * Include the old code for reset vector and protected mode entry. That code has



More information about the coreboot-gerrit mailing list