[coreboot-gerrit] New patch to review for filo: builtins: Only build dumppm and io on x86

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Thu Apr 14 02:24:30 CEST 2016


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14358

-gerrit

commit e8719d385d3bfc1d8c6535632ef599ba93b4aa15
Author: Stefan Reinauer <stefan.reinauer at coreboot.org>
Date:   Wed Apr 13 17:23:52 2016 -0700

    builtins: Only build dumppm and io on x86
    
    They're architecture specific.
    
    Change-Id: Icc37317a3911a29ca3b472816e6213b688383cdb
    Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
---
 main/grub/builtins.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/main/grub/builtins.c b/main/grub/builtins.c
index 8784be6..3f6daf2 100644
--- a/main/grub/builtins.c
+++ b/main/grub/builtins.c
@@ -458,6 +458,7 @@ static struct builtin builtin_dumpmem = {
 	"Dump memory"
 };
 
+#if CONFIG_TARGET_I386
 /* dumppm */
 static int dumppm_func(char *arg, int flags)
 {
@@ -506,6 +507,7 @@ static struct builtin builtin_dumppm = {
 	"Dump Powermanagement registers"
 };
 #endif
+#endif
 
 #if CONFIG_EXPERIMENTAL
 #warning "FIND not implemented yet."
@@ -857,6 +859,7 @@ static struct builtin builtin_initrd = {
 
 
 #ifdef CONFIG_DEVELOPER_TOOLS
+#ifdef CONFIG_TARGET_I386
 /* io */
 static int io_func(char *arg, int flags)
 {
@@ -964,6 +967,7 @@ static struct builtin builtin_io = {
 	"Read/write IO ports."
 };
 #endif
+#endif
 
 /* kernel */
 static int kernel_func(char *arg, int flags)
@@ -1919,8 +1923,10 @@ struct builtin *builtin_table[] = {
 	&builtin_default,
 #ifdef CONFIG_DEVELOPER_TOOLS
 	&builtin_dumpmem,
+#ifdef CONFIG_TARGET_I386
 	&builtin_dumppm,
 #endif
+#endif
 #ifdef CONFIG_EXPERIMENTAL
 	&builtin_find,
 #endif
@@ -1931,8 +1937,10 @@ struct builtin *builtin_table[] = {
 	&builtin_hiddenmenu,
 	&builtin_initrd,
 #ifdef CONFIG_DEVELOPER_TOOLS
+#ifdef CONFIG_TARGET_I386
 	&builtin_io,
 #endif
+#endif
 	&builtin_kernel,
 	&builtin_keymap,
 	&builtin_lock,



More information about the coreboot-gerrit mailing list