[coreboot-gerrit] New patch to review for coreboot: soc/intel/quark: Fix CID 1353356 Uninitialized variable

Leroy P Leahy (leroy.p.leahy@intel.com) gerrit at coreboot.org
Tue Apr 12 22:41:12 CEST 2016


Leroy P Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14338

-gerrit

commit 9f6f2890d2e16f6e9ddcd2dbe612179fa7969df3
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Tue Apr 12 13:37:02 2016 -0700

    soc/intel/quark: Fix CID 1353356 Uninitialized variable
    
    Initialize the d_variant variable.
    
    TEST=Build and run on Galileo Gen2
    
    Change-Id: I26fba4e77f91d53b6ff9028669aa0186d3174639
    Signed-off-by: Lee Leahy <leroy.p.leahy at intel.com>
---
 src/soc/intel/quark/romstage/report_platform.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/soc/intel/quark/romstage/report_platform.c b/src/soc/intel/quark/romstage/report_platform.c
index 7ede746..6bafa58 100644
--- a/src/soc/intel/quark/romstage/report_platform.c
+++ b/src/soc/intel/quark/romstage/report_platform.c
@@ -86,8 +86,9 @@ static void report_cpu_info(void)
 		& B_ROM_FUSE_IN_SECURE_SKU));
 
 	/* TODO: Determine if this is a D variant */
+	d_variant = 0;
 	if (ecc_enabled && secure_boot)
-		d_variant = 0;	/* or 1 */
+		d_variant = 1;
 
 	/* TODO: Determine the temperature variant */
 	extended_temp = 0;



More information about the coreboot-gerrit mailing list