[coreboot-gerrit] New patch to review for coreboot: nb/amd/amdfam10: Only flag machine check exception if valid bit is set

Timothy Pearson (tpearson@raptorengineeringinc.com) gerrit at coreboot.org
Wed Apr 6 20:27:47 CEST 2016


Timothy Pearson (tpearson at raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14264

-gerrit

commit 92aa9c9877f709add23408fdd0199c5f0d4e7ba9
Author: Timothy Pearson <tpearson at raptorengineeringinc.com>
Date:   Wed Apr 6 13:24:21 2016 -0500

    nb/amd/amdfam10: Only flag machine check exception if valid bit is set
    
    Change-Id: I42d901ae9445943a863fb3ba9bda5a915f255e02
    Signed-off-by: Timothy Pearson <tpearson at raptorengineeringinc.com>
---
 src/northbridge/amd/amdfam10/misc_control.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/northbridge/amd/amdfam10/misc_control.c b/src/northbridge/amd/amdfam10/misc_control.c
index de9f342..eee5c46 100644
--- a/src/northbridge/amd/amdfam10/misc_control.c
+++ b/src/northbridge/amd/amdfam10/misc_control.c
@@ -178,7 +178,7 @@ static void misc_control_init(struct device *dev)
 		if (dimm_present) {
 			uint32_t mc4_status_high = pci_read_config32(dev, 0x4c);
 			uint32_t mc4_status_low = pci_read_config32(dev, 0x48);
-			if (mc4_status_high != 0) {
+			if ((mc4_status_high & (0x1 << 31)) && (mc4_status_high != 0xffffffff)) {
 				printk(BIOS_WARNING, "\nWARNING: MC4 Machine Check Exception detected on node %d!\n"
 					"Signature: %08x%08x\n", node, mc4_status_high, mc4_status_low);
 			}



More information about the coreboot-gerrit mailing list