[coreboot-gerrit] Patch set updated for coreboot: lint/check_lint_tests: Add script that will break all stable tests

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Tue Apr 5 00:20:33 CEST 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14198

-gerrit

commit 0eb5b160c2c20e894c2b188168220025bedd810f
Author: Martin Roth <martinroth at google.com>
Date:   Wed Mar 30 14:51:31 2016 -0600

    lint/check_lint_tests: Add script that will break all stable tests
    
    Add a script to help us verify that our lint tests are working.
    
    This isn't finished, because it should test all of the failure modes.
    Some of the tests, 008-kconfig in particular have a lot of ways
    that they can fail.
    
    Currently the Kconfig test is triggered by removing the board
    name file in test 006.  This removes the only place the config
    option for that board name is located.
    
    Change-Id: If01c6daf1c99d097a19995b4befae90a3b5db2d6
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 util/lint/check_lint_tests | 50 ++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git a/util/lint/check_lint_tests b/util/lint/check_lint_tests
new file mode 100755
index 0000000..741d245
--- /dev/null
+++ b/util/lint/check_lint_tests
@@ -0,0 +1,50 @@
+#!/bin/bash
+
+# test to make sure the lint tests fail
+SPACE=' '
+UNDERSCORE='_'
+
+#lint-stable-000-license-headers
+TESTFILE000a=src/arch/x86/thread.c
+TESTFILE000b=src/arch/power8/misc.c
+sed -i.bak 's/^[[:space:]]\*[[:space:]].*//' ${TESTFILE000a}
+sed -i.bak 's/^[[:space:]]\*[[:space:]]but WITHOUT ANY WARRANTY;//' ${TESTFILE000b}
+
+#lint-stable-003-whitespace
+TESTFILE003=src/acpi/sata.c
+sed -i.bak 's/^$/ /' ${TESTFILE003}
+
+#lint-stable-004-style-labels
+TESTFILE004=src/soc/nvidia/tegra124/spi.c
+sed -i.bak 's/^done:/ done:/' ${TESTFILE004}
+
+#lint-stable-005-board-status
+TESTFILE005a=src/mainboard/google/storm/board_info.txt
+TESTFILE005b=src/mainboard/aaeon/pfm-540i_revb/board_info.txt
+rm -f ${TESTFILE005a}
+sed -i.bak 's/^Category:.*/Category: lint/' ${TESTFILE005b}
+
+#lint-stable-006-board-name
+TESTFILE006=src/mainboard/amd/bettong/Kconfig.name
+rm -f ${TESTFILE006}
+
+#lint-stable-008-kconfig
+
+#lint-stable-009-old-licenses
+TESTFILE009=src/superio/common/conf_mode.c
+sed -i "s/for more details./for more details.\n \* You${SPACE}should${SPACE}have received a copy of the GNU General Public License\n \* along with this program; if not, write to the Free Software\n \* Foundation, Inc./" ${TESTFILE009}
+git add ${TESTFILE009}
+
+#lint-stable-010-asm-syntax
+TESTFILE010=src/arch/x86/bootblock_romcc.S
+sed -i "1s/^/.att${UNDERSCORE}syntax noprefix\n/" ${TESTFILE010}
+git add ${TESTFILE010}
+
+#lint-stable-012-executable-bit
+TESTFILE012=src/lib/libgcc.c
+chmod +x ${TESTFILE012}
+
+#lint-stable-013-site-local
+mkdir -p site-local
+TESTFILE013=$(mktemp --tmpdir=site-local)
+git add -f ${TESTFILE013}



More information about the coreboot-gerrit mailing list