[coreboot-gerrit] New patch to review for coreboot: intel/kunimitsu: Add device properties for Nuvoton code

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Fri Oct 23 13:26:11 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12162

-gerrit

commit c82eafa1eac0621aaecb57cb1dfe6d3f92e1d838
Author: Yong Zhi <yong.zhi at intel.com>
Date:   Tue Sep 22 17:16:13 2015 -0700

    intel/kunimitsu: Add device properties for Nuvoton code
    
    Add default properties for NAU8825 codec
    Change jack detecion irq to level to match the
    codec driver
    
    BUG=chrome-os-partner:44481
    BRANCH=None
    TEST=Build and Boot Kunimitsu board with this patch
    Verify Audio jack detection IRQ working
    
    Change-Id: Iaab7a7bfbab30fa0914e56477f7c6a93717b4518
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 58c45538ea6a85724f9ab1837e5cf0971611a1f8
    Original-Change-Id: I11466b8fd64b768e1e826639ba37bd6e00810370
    Original-Signed-off-by: Yong Zhi <yong.zhi at intel.com>
    Original-Signed-off-by: Fang, Yang A <yang.a.fang at intel.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/303760
    Original-Commit-Ready: Yang Fang <yang.a.fang at intel.com>
    Original-Tested-by: Yang Fang <yang.a.fang at intel.com>
    Original-Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
---
 src/mainboard/intel/kunimitsu/acpi/mainboard.asl | 40 +++++++++++++++++++++++-
 1 file changed, 39 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/intel/kunimitsu/acpi/mainboard.asl b/src/mainboard/intel/kunimitsu/acpi/mainboard.asl
index 22f8403..4f6251b 100644
--- a/src/mainboard/intel/kunimitsu/acpi/mainboard.asl
+++ b/src/mainboard/intel/kunimitsu/acpi/mainboard.asl
@@ -143,6 +143,44 @@ Scope (\_SB.PCI0.I2C4)
 		Name (_HID, "10508825")
 		Name (_DDN, "NAU88L25 Codec")
 		Name (_UID, 1)
+		Name (_DSD, Package () {
+			ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+			Package () {
+			/* Enable jack detection via JKDET pin */
+			Package () { "nuvoton,jkdet-enable", 1 },
+			/*
+			 * JKDET pin is pulled up by R389 on board.
+			 * JKDET pin polarity = active low
+			 */
+			Package () { "nuvoton,jkdet-pull-enable", 1 },
+			Package () { "nuvoton,jkdet-pull-up", 1 },
+			Package () { "nuvoton,jkdet-polarity", 1 },
+			/* VDDA(1.8) * 1.53 = 2.754 */
+			Package () { "nuvoton,micbias-voltage", 6 },
+			/* VREF Impedance = 125 kOhm */
+			Package () { "nuvoton,vref-impedance", 2 },
+			/*
+			 * Setup 4 buttons impedance according to
+			 * Android specification
+			 */
+			Package () { "nuvoton,sar-threshold-num", 4 },
+			Package () { "nuvoton,sar-threshold",
+				Package() { 0x0a, 0x14, 0x26, 0x73 } },
+			/*
+			 * Coeff 0-15 used to adjust threshold level
+			 * 0 for low resist range
+			 */
+			Package () { "nuvoton,sar-hysteresis", 0 },
+			/* SAR tracking gain based on 2.754 micbias-voltage */
+			Package () { "nuvoton,sar-voltage", 6 },
+			/* 100ms short key press debounce */
+			Package () { "nuvoton,short-key-debounce", 3 },
+			/* 2^(7+2) = 512 ms insert/eject debounce */
+			Package () { "nuvoton,jack-insert-debounce", 7 },
+			/* debounce not needed for eject normally */
+			Package () { "nuvoton,jack-eject-debounce", 0 },
+			}
+		})
 
 		Name (_CRS, ResourceTemplate()
 		{
@@ -153,7 +191,7 @@ Scope (\_SB.PCI0.I2C4)
 				AddressingMode7Bit,
 				"\\_SB.PCI0.I2C4",
 			)
-			Interrupt (ResourceConsumer, Edge, ActiveLow)
+			Interrupt (ResourceConsumer, Level, ActiveLow)
 			{
 				BOARD_HP_MIC_CODEC_IRQ
 			}



More information about the coreboot-gerrit mailing list