[coreboot-gerrit] New patch to review for coreboot: coreboot: make lb_framebuffer a weak function

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Fri Oct 23 13:25:46 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12140

-gerrit

commit 245e55071125f0329262edd7d432181ff1930e5d
Author: robbie zhang <robbie.zhang at intel.com>
Date:   Thu Oct 1 16:06:47 2015 -0700

    coreboot: make lb_framebuffer a weak function
    
    This is to support other gfx enable method such as Gfx Peim (AKA GOP)
    for Intel soc.
    
    BRANCH=none
    BUG=chrome-os-partner:44559
    TEST=Built and boot on kunimitsu/glados.
    
    Change-Id: Ib8010ea6901ea906a8b4129807b94ace71ef1165
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: ad26a99560009c487070cccf6ab132188b9e247d
    Original-Change-Id: Id132718a8bcec5446cc4c0d9d636d26e8a99bb15
    Original-Signed-off-by: robbie zhang <robbie.zhang at intel.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/303801
    Original-Commit-Ready: Robbie Zhang <robbie.zhang at intel.com>
    Original-Tested-by: Robbie Zhang <robbie.zhang at intel.com>
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
 src/include/boot/coreboot_tables.h | 3 +++
 src/lib/coreboot_table.c           | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/include/boot/coreboot_tables.h b/src/include/boot/coreboot_tables.h
index b190a2d..ff942f1 100644
--- a/src/include/boot/coreboot_tables.h
+++ b/src/include/boot/coreboot_tables.h
@@ -19,6 +19,9 @@ void lb_add_console(uint16_t consoletype, void *data);
 /* Define this in mainboard.c to add board-specific table entries. */
 void lb_board(struct lb_header *header);
 
+/* Define this in soc or fsp driver to add specific table entries. */
+void lb_framebuffer(struct lb_header *header);
+
 /*
  * Function to retrieve MAC address(es) from the VPD and store them in the
  * coreboot table.
diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c
index 35341ab..1aa157f 100644
--- a/src/lib/coreboot_table.c
+++ b/src/lib/coreboot_table.c
@@ -133,7 +133,7 @@ void lb_add_console(uint16_t consoletype, void *data)
 	console->type = consoletype;
 }
 
-static void lb_framebuffer(struct lb_header *header)
+void __attribute__((weak)) lb_framebuffer(struct lb_header *header)
 {
 #if CONFIG_FRAMEBUFFER_KEEP_VESA_MODE || CONFIG_MAINBOARD_DO_NATIVE_VGA_INIT
 	void fill_lb_framebuffer(struct lb_framebuffer *framebuffer);



More information about the coreboot-gerrit mailing list