[coreboot-gerrit] New patch to review for coreboot: auron: Remove duplicate pei_data assignment

Marc Jones (marc@marcjonesconsulting.com) gerrit at coreboot.org
Fri Oct 16 00:50:48 CEST 2015


Marc Jones (marc at marcjonesconsulting.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11912

-gerrit

commit f6b07c131498a63a1beedef24c0285bdd3c34b23
Author: Shawn Nematbakhsh <shawnn at chromium.org>
Date:   Wed Dec 10 12:03:55 2014 -0800

    auron: Remove duplicate pei_data assignment
    
    Merge artifact -- don't check spd_index twice.
    
    BUG=None
    TEST=Build only
    BRANCH=Auron
    
    Original-Change-Id: I0cc372fec415646854aa931949ed0f57b473cb01
    Original-Signed-off-by: Shawn Nematbakhsh <shawnn at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/234421
    Original-Reviewed-by: Bernie Thompson <bhthompson at chromium.org>
    
    (cherry picked from commit 850125141b52886c845161434a1320676e59534d)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    
    Change-Id: I0070e3f26ebddba716905ebb934bcec4715c4b05
---
 src/mainboard/google/auron/spd/spd.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/mainboard/google/auron/spd/spd.c b/src/mainboard/google/auron/spd/spd.c
index 4f35477..ce37524 100644
--- a/src/mainboard/google/auron/spd/spd.c
+++ b/src/mainboard/google/auron/spd/spd.c
@@ -110,9 +110,6 @@ void mainboard_fill_spd_data(struct pei_data *pei_data)
 	if (!spd_file)
 		die("SPD data not found.");
 
-	if (spd_index > 3)
-		pei_data->dimm_channel1_disabled = 3;
-
 	if (spd_file_len < ((spd_index + 1) * SPD_LEN)) {
 		printk(BIOS_ERR, "SPD index override to 0 - old hardware?\n");
 		spd_index = 0;



More information about the coreboot-gerrit mailing list