[coreboot-gerrit] New patch to review for coreboot: intel/fsp1_0: Pass in dummy parameters for TempRamInit call

York Yang (york.yang@intel.com) gerrit at coreboot.org
Wed Oct 14 16:22:54 CEST 2015


York Yang (york.yang at intel.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11895

-gerrit

commit 45f4402010169789921cb01c51efc66d612e5811
Author: York Yang <york.yang at intel.com>
Date:   Wed Oct 14 06:52:32 2015 -0700

    intel/fsp1_0: Pass in dummy parameters for TempRamInit call
    
    Leave MCU load in coreboot bootblock and pass in dummy parameters when
    calling TempRamInit API. TempRamInit will return success only when a MCU
    has been loaded. It is safer than assuming CAR is setup even the
    TempRamInit API returns failure and proceeding with that assumption.
    
    Change-Id: I8247c0503c8eb3d1c8eaa059632fb3a11c9daae9
    Signed-off-by: York Yang <york.yang at intel.com>
---
 src/drivers/intel/fsp1_0/cache_as_ram.inc | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/drivers/intel/fsp1_0/cache_as_ram.inc b/src/drivers/intel/fsp1_0/cache_as_ram.inc
index d1167b1..418ac4f 100644
--- a/src/drivers/intel/fsp1_0/cache_as_ram.inc
+++ b/src/drivers/intel/fsp1_0/cache_as_ram.inc
@@ -124,11 +124,14 @@ fake_fsp_stack:
 	.long  find_fsp_ret
 
 CAR_init_params:
-	.long  CONFIG_CPU_MICROCODE_CBFS_LOC
-	.long  MICROCODE_REGION_LENGTH
+	.long  fake_mcu
+	.long  4
 	.long  0xFFFFFFFF - CACHE_ROM_SIZE + 1	/* Firmware Location */
 	.long  CACHE_ROM_SIZE	/* Total Firmware Length */
 
 CAR_init_stack:
 	.long  CAR_init_done
 	.long  CAR_init_params
+
+fake_mcu:
+	.long  0



More information about the coreboot-gerrit mailing list