[coreboot-gerrit] New patch to review for coreboot: intel/d945gclf: Fix IASL warning and remark

[Martin Roth (martinroth@google.com)]

Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12523

-gerrit

commit 2aac1b916d4e87f5e60f9e4c3b50e8054c3193c4
Author: Martin Roth <martinroth at google.com>
Date:   Mon Nov 23 16:34:10 2015 -0700

    intel/d945gclf: Fix IASL warning and remark
    
    - Add an empty Operating Region for the empty _REG method
    - Serialize _CRS Method
    - Remove Kconfig default disabling IASL warnings as errors
    
    dsdt.aml   1445:  Method (_CRS, 0)
    Remark   2120 -             ^ Control Method should be made Serialized
    (due to creation of named objects within)
    dsdt.aml   1454:  Method (_REG, 2)
    Warning  3079 -             ^ _REG has no corresponding Operation Region
    
    Change-Id: I2b64609c929af62c2b699762206e5baf58fbdb8b
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 src/mainboard/intel/d945gclf/Kconfig     | 4 ----
 src/mainboard/intel/d945gclf/acpi/ec.asl | 8 +++++++-
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/mainboard/intel/d945gclf/Kconfig b/src/mainboard/intel/d945gclf/Kconfig
index 2023216..429a304 100644
--- a/src/mainboard/intel/d945gclf/Kconfig
+++ b/src/mainboard/intel/d945gclf/Kconfig
@@ -50,8 +50,4 @@ config MAX_CPUS
 	int
 	default 4
 
-# TODO: Remove this when platform ASL is fixed
-config IASL_WARNINGS_ARE_ERRORS
-	def_bool n
-
 endif # BOARD_INTEL_D945GCLF
diff --git a/src/mainboard/intel/d945gclf/acpi/ec.asl b/src/mainboard/intel/d945gclf/acpi/ec.asl
index 45e2bd1..5362bb2 100644
--- a/src/mainboard/intel/d945gclf/acpi/ec.asl
+++ b/src/mainboard/intel/d945gclf/acpi/ec.asl
@@ -18,7 +18,13 @@ Device(EC0)
 	Name (_HID, EISAID("PNP0C09"))
 	Name (_UID, 1)
 
-	Method (_CRS, 0)
+	// _REG method requires that an operation region be defined.
+	OperationRegion (ERAM, EmbeddedControl, 0x00, 0xff)
+	Field (ERAM, ByteAcc, Lock, Preserve)
+	{
+	}
+
+	Method (_CRS, 0, Serialized)
 	{
 		Name (ECMD, ResourceTemplate()
 		{