[coreboot-gerrit] New patch to review for coreboot: intel/eagleheights: Fix IASL warning _OSC must return a value

[Martin Roth (martinroth@google.com)]

Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12522

-gerrit

commit e788e4892e5cb9a80620130a5c43ad07be03403a
Author: Martin Roth <martinroth at google.com>
Date:   Mon Nov 23 16:27:53 2015 -0700

    intel/eagleheights: Fix IASL warning _OSC must return a value
    
    Not all the paths through the _OSC method returned a value.  Fortunately
    this is very common code, and was easy to copy from another file.
    
    copied from src/soc/intel/baytrail/acpi/southcluster.asl
    
    dsdt.aml  140: Method (_OSC, 4)
    Warning  3115 -          ^ Not all control paths return a value (_OSC)
    dsdt.aml  140: Method (_OSC, 4)
    Warning  3107 -          ^ Reserved method must return a value
    (Buffer required for _OSC)
    
    - Remove Kconfig default disabling IASL warnings as errors.
    
    Change-Id: Iab52f19b96468e142b06430d99ba1d9f367d126e
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 src/mainboard/intel/eagleheights/Kconfig  | 4 ----
 src/mainboard/intel/eagleheights/dsdt.asl | 7 +++++++
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/mainboard/intel/eagleheights/Kconfig b/src/mainboard/intel/eagleheights/Kconfig
index bfcb4ce..702e2af 100644
--- a/src/mainboard/intel/eagleheights/Kconfig
+++ b/src/mainboard/intel/eagleheights/Kconfig
@@ -35,8 +35,4 @@ config MAX_CPUS
 	int
 	default 4
 
-# TODO: Remove this when platform ASL is fixed
-config IASL_WARNINGS_ARE_ERRORS
-	def_bool n
-
 endif # BOARD_INTEL_EAGLEHEIGHTS
diff --git a/src/mainboard/intel/eagleheights/dsdt.asl b/src/mainboard/intel/eagleheights/dsdt.asl
index 6ad320b..0e572f7 100644
--- a/src/mainboard/intel/eagleheights/dsdt.asl
+++ b/src/mainboard/intel/eagleheights/dsdt.asl
@@ -179,6 +179,13 @@ DefinitionBlock ("DSDT", "DSDT", 1, "EAGLE", "COREBOOT", 0x0000001)
 				/* Let OS control everything */
 				Return (Arg3)
 			}
+			Else
+			{
+				/* Unrecognized UUID */
+				CreateDWordField (Arg3, 0, CDW1)
+				Or (CDW1, 4, CDW1)
+				Return (Arg3)
+			}
 		} /* End _OSC */
 
 			Method (_PRT, 0, NotSerialized)