[coreboot-gerrit] Patch merged into coreboot/master: intel/skylake: ensure the RTC time is set

gerrit at coreboot.org gerrit at coreboot.org
Fri Nov 13 00:52:58 CET 2015


the following patch was just integrated into master:
commit 685ab2a2f2335a2366e2338f0425422dd3409403
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Fri Nov 6 15:24:20 2015 -0600

    intel/skylake: ensure the RTC time is set
    
    In 2014 or so the RTC code was changed to assume the ALTCENTRY
    register (0x32) as always being utilized for creating an rtc_time.
    However, one needs to ensure it's set at least once otherwise
    the year field in rtc_time is not sane.
    
    In practice this doesn't matter unless somone wants to use the
    full year value. cmos_init() should do the same thing in the
    rtc fail case, but the machine I had never had that set correctly.
    
    BUG=chrome-os-partner:47388
    BRANCH=None
    TEST=Booted glados w/ 0xff ALTCENTRY value. New value is 0x20.
    
    Change-Id: I028f801c5d717a0018ed00df82c25b466d64670c
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 7d5be5bc697bef60a264ddc7f67755aa96088d36
    Original-Change-Id: I6e12a30c9e08d8c1002e4cef0f143f0f88009e92
    Original-Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/311264
    Original-Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-on: http://review.coreboot.org/12411
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/12411 for details.

-gerrit



More information about the coreboot-gerrit mailing list