[coreboot-gerrit] Patch merged into coreboot/master: elog: fix improper assumption for year values

gerrit at coreboot.org gerrit at coreboot.org
Fri Nov 13 00:52:51 CET 2015


the following patch was just integrated into master:
commit c41c6a44127620a61b0a36b3d9b55cc13429c5cd
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Fri Nov 6 15:20:23 2015 -0600

    elog: fix improper assumption for year values
    
    The elog format stores the year of the event in bcd format.
    Semi-recently rtc_get() started returning the full year,
    e.g. 2015. However, bin2bcd takes a uint8_t as a parameter.
    Converting a full year (2015 or 0x7df) to a uint8_t results
    in passing bad values (223 or 0xdf) to bin2bcd. In other words
    the input value of bin2bcd needs to be a number between 0 and 99.
    Therefore fix that mistake.
    
    BUG=chrome-os-partner:47388
    BRANCH=None
    TEST=Events show up with correct year in eventlog now.
    
    Change-Id: I9209cb9175c0b4925337e2e5d4fea8316b30022a
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 95a86013234dc999c988291f636e2db3803cc24a
    Original-Change-Id: I12734bc3a423ba9d739658b8edc402b8d445f22e
    Original-Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/311263
    Original-Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-on: http://review.coreboot.org/12410
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/12410 for details.

-gerrit



More information about the coreboot-gerrit mailing list