[coreboot-gerrit] Patch set updated for coreboot: pcengines/apu1: disable unused clock outputs

Felix Held (felix-coreboot@felixheld.de) gerrit at coreboot.org
Fri Nov 6 18:33:28 CET 2015


Felix Held (felix-coreboot at felixheld.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12082

-gerrit

commit 9d473fab9967f4d95bcabd612349513b9988207a
Author: Felix Held <felix-coreboot at felixheld.de>
Date:   Fri Nov 6 18:31:01 2015 +0100

    pcengines/apu1: disable unused clock outputs
    
    disable unconnected FCH clock outputs to save some power
    
    Change-Id: Ib3efebb8656392d58d762c23827168017d273de8
    Signed-off-by: Felix Held <felix-coreboot at felixheld.de>
---
 src/mainboard/pcengines/apu1/mainboard.c    | 12 ++++++++++++
 src/mainboard/pcengines/apu1/platform_cfg.h |  4 ++--
 2 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/src/mainboard/pcengines/apu1/mainboard.c b/src/mainboard/pcengines/apu1/mainboard.c
index f80f24e..82cf992 100644
--- a/src/mainboard/pcengines/apu1/mainboard.c
+++ b/src/mainboard/pcengines/apu1/mainboard.c
@@ -183,6 +183,18 @@ static void mainboard_enable(device_t dev)
 
 	config_gpio_mux();
 
+	/* Power off unused clock pins of GPP PCIe devices */
+	u8 *misc_mem_clk_cntrl = (u8 *)(ACPI_MMIO_BASE + MISC_BASE);
+	/* GPP CLK0-2 are connected to the 3 ethernet chips
+	 * GPP CLK3-4 are connected to the miniPCIe slots */
+	write8(misc_mem_clk_cntrl + 0, 0xFF);
+	write8(misc_mem_clk_cntrl + 1, 0xFF);
+	/* GPP CLK5 is only connected to test pads -> disable */
+	write8(misc_mem_clk_cntrl + 2, 0x0F);
+	/* disable unconnected GPP CLK6-8 and SLT_GFX_CLK */
+	write8(misc_mem_clk_cntrl + 3, 0x00);
+	write8(misc_mem_clk_cntrl + 4, 0x00);
+
 	/* Initialize the PIRQ data structures for consumption */
 	pirq_setup();
 }
diff --git a/src/mainboard/pcengines/apu1/platform_cfg.h b/src/mainboard/pcengines/apu1/platform_cfg.h
index 946f238..7172e82 100644
--- a/src/mainboard/pcengines/apu1/platform_cfg.h
+++ b/src/mainboard/pcengines/apu1/platform_cfg.h
@@ -69,12 +69,12 @@
  *   0 - disable
  *   1 - enable
  *  PCI SLOT 0 define at BIT0
- *  PCI SLOT 1 define at BIT1
+ *  PCI SLOT 1 define at BIT1 -> connected to LPC devices
  *  PCI SLOT 2 define at BIT2
  *  PCI SLOT 3 define at BIT3
  *  PCI SLOT 4 define at BIT4
  */
-#define PCI_CLOCK_CTRL			0x1F
+#define PCI_CLOCK_CTRL			0x02
 
 /**
  * @def SATA_CONTROLLER



More information about the coreboot-gerrit mailing list