[coreboot-gerrit] New patch to review for coreboot: intel/kunimitsu, google/glados: Enable Fan control support

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Wed Nov 4 15:34:06 CET 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12323

-gerrit

commit f1de9f7215038a41e1da1f31a338d105eb82e6b7
Author: Sumeet Pawnikar <sumeet.r.pawnikar at intel.com>
Date:   Mon Oct 19 14:57:43 2015 +0530

    intel/kunimitsu, google/glados: Enable Fan control support
    
    This patch enables the Fan thermal participant device
    in the device tree for thermal active cooling action
    for DPTF on SKL-U fan based kunimitsu board.
    This patch defines the _ART table in dptf ASL file.
    With active cooling policy (_ART), we can control the
    fan on/off and speed.
    
    BRANCH=None
    BUG=chrome-os-partner:46493
    TEST=Built for kunimitsu board. Tested to see that the
    thermal devices and the participants are enumerated and
    can be seen in the /sys/bus/platform/devices. Also,
    checked the FAN type the cooling devices enumerated
    in the /sys/class/thermal with sysfs interface.
    
    Change-Id: I40c540dad32beefe249f025b570c347d3ad08c36
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 82ae11643ca23e65780006f3890f1d173363b8af
    Original-Change-Id: If44b358052a677d13c74919f09a3eb89611fccad
    Original-Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar at intel.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/307028
    Original-Commit-Ready: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
    Original-Tested-by: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
    Original-Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
    Original-Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
---
 src/mainboard/google/glados/acpi/dptf.asl   |  3 +++
 src/mainboard/intel/kunimitsu/acpi/dptf.asl | 37 +++++++++++++++++++++++++++++
 2 files changed, 40 insertions(+)

diff --git a/src/mainboard/google/glados/acpi/dptf.asl b/src/mainboard/google/glados/acpi/dptf.asl
index aebc7b2..8e96315 100644
--- a/src/mainboard/google/glados/acpi/dptf.asl
+++ b/src/mainboard/google/glados/acpi/dptf.asl
@@ -45,6 +45,9 @@
 /* SKL-Y EC already has a custom charge profile based on temperature. */
 #undef DPTF_ENABLE_CHARGER
 
+/* SKL-Y is Fanless design. */
+#undef DPTF_ENABLE_FAN_CONTROL
+
 Name (DTRT, Package () {
 	/* CPU Throttle Effect on CPU */
 	Package () { \_SB.PCI0.B0D4, \_SB.PCI0.B0D4, 100, 50, 0, 0, 0, 0 },
diff --git a/src/mainboard/intel/kunimitsu/acpi/dptf.asl b/src/mainboard/intel/kunimitsu/acpi/dptf.asl
index 73ed77b..2eea804 100644
--- a/src/mainboard/intel/kunimitsu/acpi/dptf.asl
+++ b/src/mainboard/intel/kunimitsu/acpi/dptf.asl
@@ -38,6 +38,7 @@
 #define DPTF_TSR2_CRITICAL	70
 
 #define DPTF_ENABLE_CHARGER
+#define DPTF_ENABLE_FAN_CONTROL
 
 /* Charger performance states, board-specific values from charger and EC */
 Name (CHPS, Package () {
@@ -48,6 +49,42 @@ Name (CHPS, Package () {
 	Package () { 0, 0, 0, 0, 0, 0x000, "mA", 0 },	/* 0.0A */
 })
 
+#ifdef DPTF_ENABLE_FAN_CONTROL
+/* DFPS: Fan Performance States */
+Name (DFPS, Package () {
+	0,	// Revision
+	/*
+	 * TODO : Need to update this Table after characterization.
+	 *	  These are initial reference values.
+	 */
+	/* Control, Trip Point, Speed, NoiseLevel, Power */
+	Package () {100,	0xFFFFFFFF,	4986,	220,	2200},
+	Package () {90,		0xFFFFFFFF,	4804,	180,	1800},
+	Package () {80,		0xFFFFFFFF,	4512,	145,	1450},
+	Package () {70,		0xFFFFFFFF,	4204,	115,	1150},
+	Package () {60,		0xFFFFFFFF,	3838,	90,	900},
+	Package () {50,		0xFFFFFFFF,	3402,	65,	650},
+	Package () {40,		0xFFFFFFFF,	2904,	45,	450},
+	Package () {30,		0xFFFFFFFF,	2337,	30,	300},
+	Package () {20,		0xFFFFFFFF,	1608,	15,	150},
+	Package () {10,		0xFFFFFFFF,	800,	10,	100},
+	Package () {0,		0xFFFFFFFF,	0,	0,	50}
+})
+
+Name (DART, Package () {
+	/* Fan effect on CPU */
+	0,	// Revision
+	Package () {
+		/*
+		 * Source, Target, Weight, AC0, AC1, AC2, AC3, AC4, AC5, AC6,
+		 *	AC7, AC8, AC9
+		 */
+		\_SB.DPTF.TFN1, \_SB.PCI0.B0D4, 100, 100, 90, 80, 70, 60, 0, 0,
+			0, 0, 0
+	}
+})
+#endif
+
 Name (DTRT, Package () {
 	/* CPU Throttle Effect on CPU */
 	Package () { \_SB.PCI0.B0D4, \_SB.PCI0.B0D4, 100, 50, 0, 0, 0, 0 },



More information about the coreboot-gerrit mailing list