[coreboot-gerrit] New patch to review for coreboot: 69019e8 intel/fsp_baytrail: Fix SD card when eMMC in disabled

[David Imhoff (dimhoff_devel@xs4all.nl)]

David Imhoff (dimhoff_devel at xs4all.nl) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10167

-gerrit

commit 69019e86d6fc9adbd5588dd3213df922bc8fa501
Author: David Imhoff <dimhoff_devel at xs4all.nl>
Date:   Sun May 10 17:10:05 2015 +0200

    intel/fsp_baytrail: Fix SD card when eMMC in disabled
    
    Always tell the FSP to initialise one of the eMMC controllers. This is a
    work around to make the SD card reader work. I haven't got a clue why
    this is needed.
    
    TEST=Intel/MinnowMax
    
    Change-Id: Ic51dca8e54eb34bf6dbf9967e7cb86d635cf8751
    Signed-off-by: David Imhoff <dimhoff_devel at xs4all.nl>
---
 src/soc/intel/fsp_baytrail/fsp/chipset_fsp_util.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/soc/intel/fsp_baytrail/fsp/chipset_fsp_util.c b/src/soc/intel/fsp_baytrail/fsp/chipset_fsp_util.c
index adfee6f..86e4b3e 100644
--- a/src/soc/intel/fsp_baytrail/fsp/chipset_fsp_util.c
+++ b/src/soc/intel/fsp_baytrail/fsp/chipset_fsp_util.c
@@ -114,7 +114,9 @@ static void ConfigureDefaultUpdData(FSP_INFO_HEADER *FspInfo, UPD_DATA_REGION *U
 	UPD_DEFAULT_CHECK(TxeUmaEnable);
 
 	if (config->PcdeMMCBootMode == EMMC_FOLLOWS_DEVICETREE)
-		UpdData->PcdeMMCBootMode = 0;
+		/* Hack: always tell FSP to initialize one of the eMMC
+		 * controllers else SD card doesn't work */
+		UpdData->PcdeMMCBootMode = EMMC_AUTO - EMMC_DISABLED;
 	else if ((config->PcdeMMCBootMode != EMMC_USE_DEFAULT))
 		UpdData->PcdeMMCBootMode = config->PcdeMMCBootMode - EMMC_DISABLED;