[coreboot-gerrit] New patch to review for coreboot: 513b9c8 fix build with x86_64 gcc

Gerd Hoffmann (kraxel@redhat.com) gerrit at coreboot.org
Thu Mar 26 17:41:18 CET 2015


Gerd Hoffmann (kraxel at redhat.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9053

-gerrit

commit 513b9c881de8d7a0930cdb96e8cfaee69b72ffcb
Author: Gerd Hoffmann <kraxel at redhat.com>
Date:   Thu Mar 26 17:38:03 2015 +0100

    fix build with x86_64 gcc
    
    Commit f69a99dbf843da7f4c2b4965004140d2ea83cd67 overrides CFLAGS_x86_32,
    which looses (among other things) -m32, which in turn breaks the build
    with the standard distro gcc on a x86_64 machine.
    
    Fix it by appending the new flags instead.
    
    Change-Id: Ic3409a1aaa5b26139847258a7eb5c3468efdc6a3
    Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>
---
 toolchain.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/toolchain.inc b/toolchain.inc
index d69fe26..2096de9 100644
--- a/toolchain.inc
+++ b/toolchain.inc
@@ -67,7 +67,7 @@ CFLAGS_arm64 := -ffunction-sections -fdata-sections
 CFLAGS_mipsel	:= -mips32r2 -G 0  -ffunction-sections -fdata-sections
 CFLAGS_mipsel	+= -mno-abicalls -fno-pic
 
-CFLAGS_x86_32 := -ffunction-sections -fdata-sections
+CFLAGS_x86_32 += -ffunction-sections -fdata-sections
 
 toolchain_to_dir = \
 	$(foreach arch,$(ARCH_SUPPORTED),\



More information about the coreboot-gerrit mailing list